[PATCH i-g-t v2 21/43] lib/vkms: Test attaching encoders to CRTCs
José Expósito
jose.exposito89 at gmail.com
Thu Mar 13 17:32:56 UTC 2025
Add helpers to attach and detach encoders and CRTCs and a test checking
the different valid and invalid cases.
Signed-off-by: José Expósito <jose.exposito89 at gmail.com>
---
lib/igt_vkms.c | 46 ++++++++++++++++++++++++++
lib/igt_vkms.h | 6 ++++
tests/vkms/vkms_configfs.c | 66 ++++++++++++++++++++++++++++++++++++++
3 files changed, 118 insertions(+)
diff --git a/lib/igt_vkms.c b/lib/igt_vkms.c
index ea18816e7..b6f22721d 100644
--- a/lib/igt_vkms.c
+++ b/lib/igt_vkms.c
@@ -364,6 +364,21 @@ void igt_vkms_get_encoder_path(igt_vkms_t *dev, const char *name, char *path,
get_pipeline_item_path(dev, VKMS_PIPELINE_ITEM_ENCODER, name, path, len);
}
+/**
+ * igt_vkms_get_encoder_possible_crtcs_path:
+ * @dev: Device containing the encoder
+ * @name: Encoder name
+ * @path: Output path
+ * @len: Maximum @path length
+ *
+ * Returns the encoder "possible_crtcs" directory path.
+ */
+void igt_vkms_get_encoder_possible_crtcs_path(igt_vkms_t *dev, const char *name,
+ char *path, size_t len)
+{
+ get_attach_dir_path(dev, VKMS_PIPELINE_ITEM_ENCODER, name, path, len);
+}
+
/**
* igt_vkms_get_connector_path:
* @dev: Device containing the connector
@@ -707,6 +722,37 @@ void igt_vkms_device_add_encoder(igt_vkms_t *dev, const char *name)
add_pipeline_item(dev, VKMS_PIPELINE_ITEM_ENCODER, name);
}
+/**
+ * igt_vkms_encoder_attach_crtc:
+ * @dev: Target device
+ * @encoder_name: Target encoder name
+ * @crtc_name: Destination CRTC name
+ *
+ * Attach an encoder to a CRTC. Return true on success and false on error.
+ */
+bool igt_vkms_encoder_attach_crtc(igt_vkms_t *dev, const char *encoder_name,
+ const char *crtc_name)
+{
+ return attach_pipeline_item(dev, VKMS_PIPELINE_ITEM_ENCODER,
+ encoder_name, VKMS_PIPELINE_ITEM_CRTC,
+ crtc_name);
+}
+
+/**
+ * igt_vkms_encoder_detach_crtc:
+ * @dev: Target device
+ * @encoder_name: Target encoder name
+ * @crtc_name: Destination CRTC name
+ *
+ * Detach an encoder from a CRTC. Return true on success and false on error.
+ */
+bool igt_vkms_encoder_detach_crtc(igt_vkms_t *dev, const char *encoder_name,
+ const char *crtc_name)
+{
+ return detach_pipeline_item(dev, VKMS_PIPELINE_ITEM_ENCODER,
+ encoder_name, crtc_name);
+}
+
/**
* igt_vkms_device_add_connector:
* @dev: Device to add the connector to
diff --git a/lib/igt_vkms.h b/lib/igt_vkms.h
index 58896790b..2dd91df9d 100644
--- a/lib/igt_vkms.h
+++ b/lib/igt_vkms.h
@@ -35,6 +35,8 @@ void igt_vkms_get_crtc_writeback_path(igt_vkms_t *dev, const char *name,
char *path, size_t len);
void igt_vkms_get_encoder_path(igt_vkms_t *dev, const char *name, char *path,
size_t len);
+void igt_vkms_get_encoder_possible_crtcs_path(igt_vkms_t *dev, const char *name,
+ char *path, size_t len);
void igt_vkms_get_connector_path(igt_vkms_t *dev, const char *name, char *path,
size_t len);
void igt_vkms_get_connector_status_path(igt_vkms_t *dev, const char *name,
@@ -61,6 +63,10 @@ void igt_vkms_crtc_set_writeback_enabled(igt_vkms_t *dev, const char *name,
bool writeback);
void igt_vkms_device_add_encoder(igt_vkms_t *dev, const char *name);
+bool igt_vkms_encoder_attach_crtc(igt_vkms_t *dev, const char *encoder_name,
+ const char *crtc_name);
+bool igt_vkms_encoder_detach_crtc(igt_vkms_t *dev, const char *encoder_name,
+ const char *crtc_name);
void igt_vkms_device_add_connector(igt_vkms_t *dev, const char *name);
int igt_vkms_connector_get_status(igt_vkms_t *dev, const char *name);
diff --git a/tests/vkms/vkms_configfs.c b/tests/vkms/vkms_configfs.c
index 5ee03ed2f..fdbfa61a6 100644
--- a/tests/vkms/vkms_configfs.c
+++ b/tests/vkms/vkms_configfs.c
@@ -642,6 +642,71 @@ static void test_attach_plane_to_crtc(void)
igt_vkms_device_destroy(dev2);
}
+/**
+ * SUBTEST: attach-encoder-to-crtc
+ * Description: Check that errors are handled while attaching encoders to CRTCs.
+ */
+
+static void test_attach_encoder_to_crtc(void)
+{
+ igt_vkms_t *dev1;
+ igt_vkms_t *dev2;
+ char plane1[PATH_MAX];
+ char crtc1[PATH_MAX];
+ char encoder1[PATH_MAX];
+ char plane1_type_path[PATH_MAX];
+ char crtc2[PATH_MAX];
+ bool ok;
+
+ dev1 = igt_vkms_device_create("test_attach_encoder_to_crtc_1");
+ igt_assert(dev1);
+
+ dev2 = igt_vkms_device_create("test_attach_encoder_to_crtc_2");
+ igt_assert(dev2);
+
+ igt_vkms_device_add_plane(dev1, "plane1");
+ igt_vkms_device_add_crtc(dev1, "crtc1");
+ igt_vkms_device_add_encoder(dev1, "encoder1");
+ igt_vkms_device_add_crtc(dev2, "crtc2");
+
+ igt_vkms_get_plane_path(dev1, "plane1", plane1, sizeof(plane1));
+ igt_vkms_get_crtc_path(dev1, "crtc1", crtc1, sizeof(crtc1));
+ igt_vkms_get_encoder_possible_crtcs_path(dev1, "encoder1", encoder1,
+ sizeof(encoder1));
+ igt_vkms_get_crtc_path(dev2, "crtc2", crtc2, sizeof(crtc2));
+ igt_vkms_get_plane_type_path(dev1, "plane1", plane1_type_path,
+ sizeof(plane1_type_path));
+
+ /* Error: Attach a encoder to a plane */
+ ok = attach(encoder1, plane1, "plane");
+ igt_assert_f(!ok, "Attaching encoder1 to plane1 should fail\n");
+
+ /* Error: Attach a encoder to a random file */
+ ok = attach(encoder1, plane1_type_path, "file");
+ igt_assert_f(!ok, "Attaching encoder1 to a random file should fail\n");
+
+ /* Error: Attach a encoder to a CRTC from other device */
+ ok = attach(encoder1, crtc2, "crtc2");
+ igt_assert_f(!ok, "Attaching encoder1 to crtc2 should fail\n");
+
+ /* OK: Attaching encoder1 to crtc1 */
+ ok = igt_vkms_encoder_attach_crtc(dev1, "encoder1", "crtc1");
+ igt_assert_f(ok, "Error attaching plane1 to crtc1\n");
+
+ /* Error: Attaching encoder1 to crtc1 twice */
+ ok = attach(encoder1, crtc1, "crtc1_duplicated");
+ igt_assert_f(!ok, "Error attaching encoder1 to crtc1 twice should fail");
+
+ /* OK: Detaching and attaching again */
+ ok = igt_vkms_encoder_detach_crtc(dev1, "encoder1", "crtc1");
+ igt_assert_f(ok, "Error detaching encoder1 from crtc1\n");
+ ok = igt_vkms_encoder_attach_crtc(dev1, "encoder1", "crtc1");
+ igt_assert_f(ok, "Error attaching encoder1 to crtc1\n");
+
+ igt_vkms_device_destroy(dev1);
+ igt_vkms_device_destroy(dev2);
+}
+
igt_main
{
struct {
@@ -665,6 +730,7 @@ igt_main
{ "connector-wrong-values", test_connector_wrong_values },
{ "connector-valid-values", test_connector_valid_values },
{ "attach-plane-to-crtc", test_attach_plane_to_crtc },
+ { "attach-encoder-to-crtc", test_attach_encoder_to_crtc },
};
igt_fixture {
--
2.48.1
More information about the igt-dev
mailing list