[PATCH i-g-t 0/1] Close sysfs and debugfs test gap between i915 and Xe
Peter Senna Tschudin
peter.senna at linux.intel.com
Tue Mar 18 09:53:49 UTC 2025
The existing tests/intel/debugfs_test.c scans and reads all relevant
files from sysfs and debugfs, but it is specific to i915, leaving a gap
for Xe.
A similar test exists for Xe in tests/intel/xe_debugfs.c, but it has two
gaps compared to the i915 counterpart:
- It lacks sysfs file testing.
- It does not attempt to read all debugfs files.
This commit addresses these gaps by adding two new tests to
tests/intel/xe_debugfs.c:
- sysfs_read_all_entries
- debugfs_read_all_entries
Both tests use the function read_and_discard_sysfs_entries(), which was
copied from tests/intel/debugfs_test.c.
Follow-up improvements
Once this patch is merged, I will submit a follow-up series to address
the following improvements:
- Rename tests/intel/debugfs_test -> i915_debugfs_sysfs: The current
name is misleading because it is i915-specific and covers both
debugfs and sysfs.
- Rename tests/intel/xe_debugfs -> xe_debugfs_sysfs
- Remove redundant hwmon-basic from debugfs_test: The existing hwmon
test is redundant since tests/intel/intel_hwmon.c already provides
dedicated coverage for both i915 and Xe.
- Move read_and_discard_sysfs_entries() to lib/: This function is used
by both debugfs_test.c and xe_debugfs.c, so it should be placed in a
shared location.
Why I am sending this patch first
The priority is to close the sysfs and debugfs testing gap between i915
and Xe now, so we have more time to upstream these changes. While the
follow-up improvements are relatively simple, they carry short-term
risks because:
- The hwmon test removal could impact existing test lists.
- The current test names (debugfs_test.c and xe_debugfs.c) are
referenced in documentation and test configurations.
By addressing the test gap first, we can ensure proper coverage while
minimizing disruption. The follow-up series will refine the structure
and naming to improve long-term maintainability.
Cc: rodrigo.vivi at intel.com
Cc: katarzyna.piecielska at intel.com
Peter Senna Tschudin (1):
tests/intel/xe_debugfs: Add tests to read all debugfs and sysfs files
tests/intel/xe_debugfs.c | 88 +++++++++++++++++++++++++++++++++++++++-
1 file changed, 87 insertions(+), 1 deletion(-)
--
2.34.1
More information about the igt-dev
mailing list