[PATCH 3/4] scripts/generate_iga64_codes: fix handling empty asms
Kamil Konieczny
kamil.konieczny at linux.intel.com
Thu Mar 20 17:01:49 UTC 2025
Hi Andrzej,
On 2025-03-14 at 15:59:10 +0100, Andrzej Hajda wrote:
> Script incorrectly handled empty asms in case of the newest
> platforms.
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda at intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
> scripts/generate_iga64_codes | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/generate_iga64_codes b/scripts/generate_iga64_codes
> index 16bdc6fd6d0f..bfef0e5c2853 100755
> --- a/scripts/generate_iga64_codes
> +++ b/scripts/generate_iga64_codes
> @@ -104,7 +104,7 @@ for asm in "${ASMS[@]}"; do
> asm_name="${asm%%:*}"
> asm_code="${asm_name/assembly/code}"
> asm_body="${asm#*:}"
> - cur_code=""
> + cur_code="NONE"
> cur_ver=""
> echo -e "\nstruct iga64_template const $asm_code[] = {" >>$OUTPUT
> for gen in $GEN_VERSIONS; do
> @@ -117,7 +117,7 @@ for asm in "${ASMS[@]}"; do
> done
> SHOW_CMD=1 compile_iga64 > "$WD/$asm_name.$gen_name.bin" || die "Cannot write to $WD/$asm_name.$gen_name.bin"
> code="$(hexdump -v -e '"\t\t" 4/4 "0x%08x, " "\n"' $WD/$asm_name.$gen_name.bin)"
> - [ -z "$cur_code" ] && cur_code="$code"
> + [ "$cur_code" = "NONE" ] && cur_code="$code"
> [ "$cur_code" != "$code" ] && {
> echo -e "\t{ .gen_ver = $cur_ver, .size = $(dword_count "$cur_code"), .code = (const uint32_t []) {\n$cur_code\n\t}}," >>$OUTPUT
> cur_code="$code"
>
> --
> 2.34.1
>
More information about the igt-dev
mailing list