[PATCH 1/4] lib/iga64: fix send macro for DG2 platforms
Zbigniew Kempczyński
zbigniew.kempczynski at intel.com
Fri Mar 21 12:58:12 UTC 2025
On Fri, Mar 14, 2025 at 03:59:08PM +0100, Andrzej Hajda wrote:
> src1 argument should be in form of null:0 for some platforms,
> use special macro src1_null for it.
>
> iga64 -Xauto-deps -Wall -p=12p71 lib/iga64_generated_codes.c.d/iga64_assembly_media_block_write_aip.12p71.asm
> line 3.31: warning: Src1.Length should suffix src1 register (e.g. r10:4)
> (W) send.dc1 (1) null r4 null 0x0 0x40A8000
LGTM:
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
--
Zbigniew
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda at intel.com>
> ---
> lib/iga64_generated_codes.c | 2 +-
> lib/iga64_macros.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/iga64_generated_codes.c b/lib/iga64_generated_codes.c
> index a74a8864e5ca..551dead2be17 100644
> --- a/lib/iga64_generated_codes.c
> +++ b/lib/iga64_generated_codes.c
> @@ -3,7 +3,7 @@
>
> #include "gpgpu_shader.h"
>
> -#define MD5_SUM_IGA64_ASMS 80bb609ce27131259d19629dc74e349f
> +#define MD5_SUM_IGA64_ASMS 22a5a4671242c3257209f4051f1c0c7e
>
> struct iga64_template const iga64_code_gpgpu_fill[] = {
> { .gen_ver = 2000, .size = 44, .code = (const uint32_t []) {
> diff --git a/lib/iga64_macros.h b/lib/iga64_macros.h
> index ac482e47c05e..8e452cf634f9 100644
> --- a/lib/iga64_macros.h
> +++ b/lib/iga64_macros.h
> @@ -70,7 +70,7 @@
> #define SET_SHARED_SPACE_ADDR(dst, y, width) SET_SHARED_MEDIA_BLOCK_MSG_HDR(dst, y, width)
> #define SET_THREAD_SPACE_ADDR(dst, x, y, width) SET_THREAD_MEDIA_BLOCK_MSG_HDR(dst, x, y, width)
> #define LOAD_SPACE_DW(dst, src) send.dc1 (1) dst src src1_null 0x0 0x2190000
> -#define STORE_SPACE_DW(dst, src) send.dc1 (1) null dst null 0x0 0x40A8000
> +#define STORE_SPACE_DW(dst, src) send.dc1 (1) null dst src1_null 0x0 0x40A8000
> #else
> #define SET_SHARED_SPACE_ADDR(dst, y, width) SET_SHARED_MEDIA_A2DBLOCK_PAYLOAD(dst, y, width)
> #define SET_THREAD_SPACE_ADDR(dst, x, y, width) SET_THREAD_MEDIA_A2DBLOCK_PAYLOAD(dst, x, y, width)
>
> --
> 2.34.1
>
More information about the igt-dev
mailing list