[PATCH i-g-t v2] scripts/test_list: Do not stop the build process if documantion fails

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Mar 21 18:50:02 UTC 2025


Hi Karthik,
On 2025-03-20 at 19:35:08 +0530, Karthik B S wrote:

small nit in subject:

> Do not stop the build process if documantion fails
-----------------------------------^^^^^^^^^^^
s/documantion/documentation/

What about also shortening it a bit?

scripts/test_list: Do not stop the build if documentation fails

Regards,
Kamil

> Current approach stops whole build process on a case that there is mistake
> on documentation. Let's have entry on logs instead and continue.
> 
> Small fix also related multiline data e.g. on Description part.
> 
> Signed-off-by: Jari Tahvanainen <jari.tahvanainen at intel.com>
> Signed-off-by: Karthik B S <karthik.b.s at intel.com>
> Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
>  scripts/test_list.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/test_list.py b/scripts/test_list.py
> index 867d28400..5f1b4218b 100644
> --- a/scripts/test_list.py
> +++ b/scripts/test_list.py
> @@ -1399,7 +1399,7 @@ class TestList:
>  
>                  # Handle multi-line field contents
>                  if current_field:
> -                    match = re.match(r'\s+(.*)', file_line)
> +                    match = re.match(r'(.*)', file_line)
>                      if match:
>                          if handle_section == 'test':
>                              dic = self.doc[current_test]
> @@ -1408,7 +1408,7 @@ class TestList:
>  
>                          if dic[current_field] != '':
>                              dic[current_field] += " "
> -                        dic[current_field] += match.group(1)
> +                        dic[current_field] += match.group(1).strip()
>                          continue
>  
>                  # Handle multi-line argument contents
> @@ -1427,7 +1427,7 @@ class TestList:
>                      continue
>  
>                  file_line.rstrip(r"\n")
> -                sys.exit(f"{fname}:{file_ln + 1}: Error: unrecognized line. Need to add field at %s?\n\t==> %s" %
> +                printf(f"{fname}:{file_ln + 1}: Warning: unrecognized line. Need to add field at %s?\n\t==> %s" %
>                           (config_origin, file_line))
>  
>      def show_subtests(self, sort_field):
> -- 
> 2.43.0
> 


More information about the igt-dev mailing list