[PATCH i-g-t] lib/intel_batchbuffer: Refactor igt_get_render_copyfunc
Dixit, Ashutosh
ashutosh.dixit at intel.com
Tue Mar 25 18:48:41 UTC 2025
On Mon, 24 Mar 2025 21:33:24 -0700, Dixit, Ashutosh wrote:
>
> On Mon, 24 Mar 2025 02:36:27 -0700, Sai Teja Pottumuttu wrote:
> >
> > +++ b/lib/intel_batchbuffer.c
> > @@ -652,9 +652,15 @@ void igt_blitter_fast_copy__raw(int fd,
> > * specified with @devid. Will return NULL when no render copy function is
> > * implemented.
> > */
> > -igt_render_copyfunc_t igt_get_render_copyfunc(int devid)
> > +igt_render_copyfunc_t igt_get_render_copyfunc(int fd)
> > {
> > igt_render_copyfunc_t copy = NULL;
> > + int devid;
> > +
> > + if(is_xe_device(fd) && !xe_has_engine_class(fd, DRM_XE_ENGINE_CLASS_RENDER))
>
> Needs a space after if. I can change that when merging, no need to
> resend. Otherwise LGTM:
>
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>
>
> But let's see if anyone else has any comments.
I also fixed up comments for igt_get_render_copyfunc() and then merged
this!
More information about the igt-dev
mailing list