[PATCH i-g-t v7 4/4] tests/kms_async_flips: Remove allow_fail flag from async flip tests

[Borah, Chaitanya Kumar]

> -----Original Message-----
> From: Reddy Guddati, Santhosh <santhosh.reddy.guddati at intel.com>
> Sent: Tuesday, March 25, 2025 5:46 PM
> To: igt-dev at lists.freedesktop.org
> Cc: B S, Karthik <karthik.b.s at intel.com>; Murthy, Arun R
> <arun.r.murthy at intel.com>; Borah, Chaitanya Kumar
> <chaitanya.kumar.borah at intel.com>; Reddy Guddati, Santhosh
> <santhosh.reddy.guddati at intel.com>
> Subject: [PATCH i-g-t v7 4/4] tests/kms_async_flips: Remove allow_fail flag
> from async flip tests
> 
> Remove allow_fail flag as the async supported format modifiers are now
> known to the user space. The test now executes for all supported format
> modifiers.
> 
> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati at intel.com>
> ---
>  tests/kms_async_flips.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c index
> 1fdd13b99..0f2ad8acf 100644
> --- a/tests/kms_async_flips.c
> +++ b/tests/kms_async_flips.c
> @@ -123,7 +123,6 @@ typedef struct {
>  	enum pipe pipe;
>  	bool alternate_sync_async;
>  	bool suspend_resume;
> -	bool allow_fail;
>  	struct buf_ops *bops;
>  	bool atomic_path;
>  	unsigned int plane_format;
> @@ -338,7 +337,7 @@ static void test_async_flip(data_t *data)
> 
>  		ret = perform_flip(data, frame, flags);
> 
> -		if (frame == 1 && data->allow_fail)
> +		if (frame == 1)
>  			igt_skip_on(ret == -EINVAL);

We can forgo with this whole block, right? Since we will not flip with an invalid modifier.

Regards

Chaitanya

>  		else
>  			igt_assert_eq(ret, 0);
> @@ -715,7 +714,6 @@ static void run_test(data_t *data, void (*test)(data_t
> *))
>  			continue;
> 
>  		test_init(data);
> -		data->allow_fail = false;
>  		data->modifier = default_modifier(data);
>  		igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(data-
> >pipe), data->output->name) {
>  			/*
> --
> 2.34.1