[PATCH i-g-t 3/3] tests/chamelium/kms_chamelium_color: Set rgb_full to 1.0
Borah, Chaitanya Kumar
chaitanya.kumar.borah at intel.com
Thu Mar 27 05:30:15 UTC 2025
> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Swati
> Sharma
> Sent: Monday, March 24, 2025 2:40 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Sharma, Swati2 <swati2.sharma at intel.com>
> Subject: [PATCH i-g-t 3/3] tests/chamelium/kms_chamelium_color: Set
> rgb_full to 1.0
>
> Set red_green_blue_full[] to 1.0 instead of 0.5
>
> Signed-off-by: Swati Sharma <swati2.sharma at intel.com>
> ---
> tests/chamelium/kms_chamelium_color.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/chamelium/kms_chamelium_color.c
> b/tests/chamelium/kms_chamelium_color.c
> index 355047ed6..4088e2eb7 100644
> --- a/tests/chamelium/kms_chamelium_color.c
> +++ b/tests/chamelium/kms_chamelium_color.c
> @@ -342,9 +342,9 @@ static bool test_pipe_limited_range_ctm(data_t
> *data,
> { 0.0, 0.0, limited_result }
> };
> color_t red_green_blue_full[] = {
> - { 0.5, 0.0, 0.0 },
> - { 0.0, 0.5, 0.0 },
> - { 0.0, 0.0, 0.5 }
> + { 1.0, 0.0, 0.0 },
> + { 0.0, 1.0, 0.0 },
> + { 0.0, 0.0, 1.0 }
This looks good but I think it also makes sense to convert the 0s in the limited range matrix to 16/255.
That should represent actual limited range of 16-235.
Also perhaps this should be part of the previous patch? Because it is important for the test to actually work.
Regards
Chaitanya
> };
> double ctm[] = { 1.0, 0.0, 0.0,
> 0.0, 1.0, 0.0,
> --
> 2.25.1
More information about the igt-dev
mailing list