[PATCH i-g-t v1 2/3] tests/kms_plane_scaling: Reduce Log Level by Skipping Unsupported Modes in Scaling Tests

Naladala Ramanaidu ramanaidu.naladala at intel.com
Thu Mar 27 20:53:00 UTC 2025


Implement a check to bypass modes that do not support scaling on
Intel hardware. Added a condition to skip tests if no compatible
mode is found, thereby reducing unnecessary log entries.

Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala at intel.com>
---
 tests/kms_plane_scaling.c | 23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 63d35d76b..40a5b098a 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -578,9 +578,15 @@ check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
 	int commit_ret;
 	int w, h;
 	int width, height;
+	bool found_mode = 0;
 
 	for_each_connector_mode(output) {
 		mode = &output->config.connector->modes[j__];
+
+		if (is_intel_device(display->drm_fd) &&
+		    !is_intel_support_scaling(mode))
+			continue;
+
 		igt_output_override_mode(output, mode);
 		igt_debug("Trying mode %dx%d\n",
 			  mode->hdisplay, mode->vdisplay);
@@ -629,9 +635,12 @@ check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
 		igt_plane_set_fb(plane, NULL);
 		igt_plane_set_position(plane, 0, 0);
 		cleanup_fbs(d);
-		if (commit_ret == 0)
+		if (commit_ret == 0) {
+			found_mode = 1;
 			break;
+		}
 	}
+	igt_skip_on_f(found_mode == 0, "No suitable mode found for required scaling operation\n");
 	return commit_ret;
 }
 
@@ -942,12 +951,19 @@ test_planes_scaling_combo(data_t *d, double sf_plane1,
 	int n_planes;
 	int w1, h1, w2, h2;
 	int ret;
+	bool found_mode = 0;
 
 	cleanup_crtc(d);
 
 	igt_output_set_pipe(output, pipe);
 	for_each_connector_mode(output) {
 		mode = &output->config.connector->modes[j__];
+
+		if (is_intel_device(display->drm_fd) &&
+		    !is_intel_support_scaling(mode)) {
+			continue;
+		}
+
 		igt_output_override_mode(output, mode);
 		igt_debug("Trying mode %dx%d\n",
 			  mode->hdisplay, mode->vdisplay);
@@ -998,9 +1014,12 @@ test_planes_scaling_combo(data_t *d, double sf_plane1,
 				break;
 		}
 		cleanup_fbs(d);
-		if (ret == 0)
+		if (ret == 0) {
+			found_mode = 1;
 			break;
+		}
 	}
+	igt_skip_on_f(found_mode == 0, "No suitable mode found for required scaling operation\n");
 	return ret;
 }
 
-- 
2.43.0



More information about the igt-dev mailing list