[PATCH v3 17/19] lib/amdgpu: make the local functions as static

Sunil Khatri sunil.khatri at amd.com
Fri Mar 28 08:24:14 UTC 2025


functions like amdgpu_alloc_doorbell and
amdgpu_bo_unmap_and_free_uq are internal function
only hence making then static and removing from
amd_user_queue.h

Signed-off-by: Sunil Khatri <sunil.khatri at amd.com>
---
 lib/amdgpu/amd_user_queue.c | 15 +++++++++------
 lib/amdgpu/amd_user_queue.h |  8 --------
 2 files changed, 9 insertions(+), 14 deletions(-)

diff --git a/lib/amdgpu/amd_user_queue.c b/lib/amdgpu/amd_user_queue.c
index 0235b07ac..5812a1be3 100644
--- a/lib/amdgpu/amd_user_queue.c
+++ b/lib/amdgpu/amd_user_queue.c
@@ -8,8 +8,9 @@
 #include "amd_PM4.h"
 #include "ioctl_wrappers.h"
 
-void amdgpu_alloc_doorbell(amdgpu_device_handle device_handle, struct amdgpu_userq_bo *doorbell_bo,
-			   unsigned int size, unsigned int domain)
+static void amdgpu_alloc_doorbell(amdgpu_device_handle device_handle,
+				  struct amdgpu_userq_bo *doorbell_bo,
+				  unsigned int size, unsigned int domain)
 {
 	struct amdgpu_bo_alloc_request req = {0};
 	amdgpu_bo_handle buf_handle;
@@ -88,10 +89,12 @@ error_va_alloc:
 	return r;
 }
 
-void amdgpu_bo_unmap_and_free_uq(amdgpu_device_handle device_handle, amdgpu_bo_handle bo,
-			    amdgpu_va_handle va_handle, uint64_t mc_addr, uint64_t size,
-			    uint32_t timeline_syncobj_handle, uint64_t point,
-			    uint64_t syncobj_handles_array, uint32_t num_syncobj_handles)
+static void amdgpu_bo_unmap_and_free_uq(amdgpu_device_handle device_handle,
+					amdgpu_bo_handle bo, amdgpu_va_handle va_handle,
+					uint64_t mc_addr, uint64_t size,
+					uint32_t timeline_syncobj_handle,
+					uint64_t point, uint64_t syncobj_handles_array,
+					uint32_t num_syncobj_handles)
 {
 	amdgpu_bo_cpu_unmap(bo);
 	amdgpu_bo_va_op_raw2(device_handle, bo, 0, size, mc_addr, 0, AMDGPU_VA_OP_UNMAP,
diff --git a/lib/amdgpu/amd_user_queue.h b/lib/amdgpu/amd_user_queue.h
index 539a78819..b29e97ccf 100644
--- a/lib/amdgpu/amd_user_queue.h
+++ b/lib/amdgpu/amd_user_queue.h
@@ -34,20 +34,12 @@
 #define amdgpu_pkt_end() \
 	*ring_context->wptr_cpu += __num_dw_written
 
-void amdgpu_alloc_doorbell(amdgpu_device_handle device_handle, struct amdgpu_userq_bo *doorbell_bo,
-			   unsigned int size, unsigned int domain);
-
 int amdgpu_bo_alloc_and_map_uq(amdgpu_device_handle device_handle, unsigned int size,
 			       unsigned int alignment, unsigned int heap, uint64_t alloc_flags,
 			       uint64_t mapping_flags, amdgpu_bo_handle *bo, void **cpu,
 			       uint64_t *mc_address, amdgpu_va_handle *va_handle,
 			       uint32_t timeline_syncobj_handle, uint64_t point);
 
-void amdgpu_bo_unmap_and_free_uq(amdgpu_device_handle device_handle, amdgpu_bo_handle bo,
-				 amdgpu_va_handle va_handle, uint64_t mc_addr, uint64_t size,
-				 uint32_t timeline_syncobj_handle, uint64_t point,
-				 uint64_t syncobj_handles_array, uint32_t num_syncobj_handles);
-
 int amdgpu_timeline_syncobj_wait(amdgpu_device_handle device_handle,
 				 uint32_t timeline_syncobj_handle, uint64_t point);
 
-- 
2.43.0



More information about the igt-dev mailing list