[PATCH v4 i-g-t 0/1] tests/intel/intel_sysfs_debugfs: Unify sysfs and debugfs testing
Rodrigo Vivi
rodrigo.vivi at intel.com
Mon Mar 31 21:56:16 UTC 2025
On Mon, Mar 31, 2025 at 08:05:35PM +0200, Peter Senna Tschudin wrote:
> The existing debugfs_test scans and reads relevant sysfs and debugfs
> files, but it is limited to i915. Meanwhile, xe_debugfs.c provides
> similar functionality for Xe but has two key gaps:
> - It lacks sysfs file testing.
> - It does not attempt to read all debugfs files.
>
> This patch introduces intel_sysfs_debugfs, unifying both tests into a single
> framework that ensures comprehensive coverage for both i915 and Xe.
>
> Follow-up improvements
>
> Once this patch is merged, I will submit a follow-up to:
> - Remove the redundant hwmon-basic test from debugfs_test, as
> intel_hwmon already provides full coverage for i915 and Xe.
> - Remove both debugfs_test and xe_debugfs.
>
> The removal of existing tests impacts external test lists, requiring
> updates that take time. By first addressing the test gap, we ensure
> complete coverage while minimizing disruption. The follow-up series will
> then focus on cleanup for improving long-term maintainability.
>
> v4:
> - remove the 5 seconds timeout to read each sysfs and debugfs file
Thanks,
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
and pushed
>
> v3:
> - rename test to intel_sysfs_debugfs
> - fix copy paste error on commit message
> - expand Cc list
>
> v2:
> - renamed xe-specific functions with the xe_ prefix
> - created two igt_subtest_groups: one for i915 and another for Xe
> - prefixed each test with either i915 or xe
>
> Cc: himanshu.girotra at intel.com
> Cc: aditya.chauhan at intel.com
> Cc: pravalika.gurram at intel.com
> Cc: sai.gowtham.ch at intel.com
> Cc: ramadevi.gandi at intel.com
> Cc: lucas.demarchi at intel.com
> Cc: rodrigo.vivi at intel.com
> Cc: kamil.konieczny at linux.intel.com
> Cc: katarzyna.piecielska at intel.com
>
> Peter Senna Tschudin (1):
> tests/intel/intel_sysfs_debugfs Unify sysfs and debugfs testing
>
> tests/intel/intel_sysfs_debugfs.c | 498 ++++++++++++++++++++++++++++++
> tests/meson.build | 1 +
> 2 files changed, 499 insertions(+)
> create mode 100644 tests/intel/intel_sysfs_debugfs.c
>
> --
> 2.43.0
>
More information about the igt-dev
mailing list