[PATCH i-g-t v2 1/2] tests/kms_plane_multiple: Add clear skip message for skips

Kamil Konieczny kamil.konieczny at linux.intel.com
Mon May 5 11:30:28 UTC 2025


Hi Pranay,
On 2025-05-05 at 09:04:34 +0530, Pranay Samala wrote:
> Add a check to skip the subtest when the required DRM modifier
> is not supported. This avoids unnecessary test skips and
> improves clarity by providing a proper skip message.
> 
> Signed-off-by: Pranay Samala <pranay.samala at intel.com>
> ---
>  tests/kms_plane_multiple.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

Please squash both patches together.

Regards,
Kamil

> diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
> index ebb026726..5767318e4 100644
> --- a/tests/kms_plane_multiple.c
> +++ b/tests/kms_plane_multiple.c
> @@ -510,8 +510,8 @@ static void run_2_display_test(data_t *data, uint64_t modifier)
>  	igt_output_t *output1, *output2;
>  	igt_display_t *display = &data->display;
>  
> -	if (!igt_display_has_format_mod(display, DRM_FORMAT_XRGB8888, modifier))
> -		return;
> +	igt_skip_on_f(!igt_display_has_format_mod(display, DRM_FORMAT_XRGB8888, modifier),
> +		      "%s modifier is not supported\n", name);
>  
>  	igt_display_reset(display);
>  
> @@ -553,8 +553,8 @@ static void run_test(data_t *data, uint64_t modifier)
>  	igt_output_t *output;
>  	igt_display_t *display = &data->display;
>  
> -	if (!igt_display_has_format_mod(display, DRM_FORMAT_XRGB8888, modifier))
> -		return;
> +	igt_skip_on_f(!igt_display_has_format_mod(display, DRM_FORMAT_XRGB8888, modifier),
> +		      "%s modifier is not supported\n", name);
>  
>  	for_each_pipe_with_valid_output(display, pipe, output) {
>  		igt_display_reset(display);
> -- 
> 2.34.1
> 


More information about the igt-dev mailing list