[PATCH i-g-t v2] tests/kms_tiled_display: Skip if connectors are not of same type
Nautiyal, Ankit K
ankit.k.nautiyal at intel.com
Wed May 7 10:32:08 UTC 2025
On 5/5/2025 9:19 AM, Pranay Samala wrote:
> Tiled display setups require all involved connectors to be of the same type
> (e.g., all eDP or all HDMI).
Currently Port Sync is supported only on DP for i915/xe.
> This patch adds a check to skip the test when
> connector types differ, preventing invalid configurations and reducing
> confusing test failures.
>
> v2: Replace igt_assert with igt_skip_on_f to skip the test.
>
> Signed-off-by: Pranay Samala <pranay.samala at intel.com>
> ---
> tests/kms_tiled_display.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/tests/kms_tiled_display.c b/tests/kms_tiled_display.c
> index 1f5331408..6d461c976 100644
> --- a/tests/kms_tiled_display.c
> +++ b/tests/kms_tiled_display.c
> @@ -149,6 +149,7 @@ static void get_connectors(data_t *data)
> int count = 0;
> igt_output_t *output;
> data_connector_t *conns = data->conns;
> + int connector_type = -1;
drmModeConnector has connector_type as uint32_t.
So better to use that and set it to : DRM_MODE_CONNECTOR_Unknown
>
> for_each_connected_output(&data->display, output) {
> conns[count].connector = drmModeGetConnector(data->display.drm_fd,
> @@ -169,6 +170,14 @@ static void get_connectors(data_t *data)
> igt_assert(conns[count].tile.tile_group_id ==
> conns[count-1].tile.tile_group_id);
>
> + if (connector_type == -1) {
> + connector_type = conns[count].connector->connector_type;
> + } else {
> + igt_skip_on_f(connector_type != conns[count].connector->connector_type,
> + "Connector type mismatch: Expected %d, but got %d\n",
> + connector_type, conns[count].connector->connector_type);
> + }
> +
> count++;
> }
> igt_require_f(count == data->num_h_tiles,
Perhaps need to check that connector_type != DRM_MODE_CONNECTOR_Unknown.
Regards,
Ankit
More information about the igt-dev
mailing list