[PATCH i-g-t] Revert "tests/intel/xe_fault_injection: Suppress GuC CT dumps"

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed May 14 07:00:36 UTC 2025


Hi Satyanarayana,
On 2025-05-14 at 10:16:51 +0530, Satyanarayana K V P wrote:
> This commit has dependency on a commit from XE. The commit from XE is
> still in review. So, reverting this commit to avoid CI test failures.

I will re-word a little above description.

> 
> This reverts commit dfe2c08db120d49e8b0ea92f20d09d6b60343da8.
> 
> Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p at intel.com>
> --
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Cc: John Harrison <John.C.Harrison at Intel.com>
> Cc: Jonathan Cavitt <jonathan.cavitt at intel.com>
> Cc: Aditya Chauhan <aditya.chauhan at intel.com>

Sorry for premature merge, so lets revert it and wait
for kernel side to be ready,

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  tests/intel/xe_fault_injection.c | 22 ----------------------
>  1 file changed, 22 deletions(-)
> 
> diff --git a/tests/intel/xe_fault_injection.c b/tests/intel/xe_fault_injection.c
> index 10374d23e..f9bd5c761 100644
> --- a/tests/intel/xe_fault_injection.c
> +++ b/tests/intel/xe_fault_injection.c
> @@ -123,22 +123,6 @@ static void injection_list_add(const char function_name[])
>  	close(dir);
>  }
>  
> -static void injection_list_append(const char function_name[])
> -{
> -	int dir, fd, ret;
> -
> -	dir = fail_function_open();
> -	igt_assert_lte(0, dir);
> -
> -	fd = openat(dir, "inject", O_WRONLY | O_APPEND);
> -	ret = write(fd, function_name, strlen(function_name));
> -
> -	close(fd);
> -	close(dir);
> -
> -	igt_assert_lte(0, ret);
> -}
> -
>  static void injection_list_remove(const char function_name[])
>  {
>  	int dir;
> @@ -252,10 +236,6 @@ inject_fault_probe(int fd, char pci_slot[], const char function_name[])
>  
>  	ignore_faults_in_dmesg(function_name);
>  	injection_list_add(function_name);
> -	if (!strcmp(function_name, "xe_guc_ct_send_recv") ||
> -	    !strcmp(function_name, "xe_guc_mmio_send_recv"))
> -		injection_list_append("xe_should_fail_ct_dead_capture");
> -
>  	set_retval(function_name, INJECT_ERRNO);
>  
>  	igt_kmod_bind("xe", pci_slot);
> @@ -293,8 +273,6 @@ static void probe_fail_guc(int fd, char pci_slot[], const char function_name[],
>  	for (int i = iter_start; i < iter_end; i++) {
>  		fault_params->space = i;
>  		setup_injection_fault(fault_params);
> -		/* Clear the injection list  */
> -		injection_list_clear();
>  		inject_fault_probe(fd, pci_slot, function_name);
>  		igt_kmod_unbind("xe", pci_slot);
>  	}
> -- 
> 2.43.0
> 


More information about the igt-dev mailing list