[PATCH i-g-t v1 1/1] tests/intel/xe_render_copy: Skip tests on PVC

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed May 14 11:19:28 UTC 2025


Hi Jan,
On 2025-05-13 at 11:52:52 +0000, Jan Sokolowski wrote:
> As PVC doesn't have render, these tests will fail by definition.
> 
> Skip render tests on PVC.

There is already igt_require later on, why not moving
it into fixture?

> 
> Signed-off-by: Jan Sokolowski <jan.sokolowski at intel.com>
> ---
>  tests/intel/xe_render_copy.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/intel/xe_render_copy.c b/tests/intel/xe_render_copy.c
> index fadfd162c..c36520c92 100644
> --- a/tests/intel/xe_render_copy.c
> +++ b/tests/intel/xe_render_copy.c
> @@ -697,6 +697,10 @@ igt_main_args("dpiW:H:", NULL, help_str, opt_handler, NULL)
>  
>  	igt_fixture {
>  		xe = drm_open_driver(DRIVER_XE);
> +
> +		/* As PVC doesn't have render, we should skip here */
> +		igt_require(!IS_PONTEVECCHIO(xe_dev_id(xe)));
> +
>  		bops = buf_ops_create(xe);

Put it here after bops create, see closing fixture.
To be sure you could also add a require with igt_get_render_copyfunc()

Regards,
Kamil

>  		srand(time(NULL));
>  		set = xe_get_memory_region_set(xe, DRM_XE_MEM_REGION_CLASS_SYSMEM);
> -- 
> 2.34.1
> 


More information about the igt-dev mailing list