[PATCH v4 13/15] lib/igt_device_scan: Replace return value of devs_compate to int

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed May 14 14:25:26 UTC 2025


Hi Jeevaka,
On 2025-05-07 at 16:01:46 +0000, Jeevaka Prabu Badrappan wrote:
> Signed-off-by: Jeevaka Prabu Badrappan <jeevaka.badrappan at intel.com>
> ---
>  lib/igt_device_scan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index 3f26a1737..7e9614429 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -949,7 +949,7 @@ static struct igt_device *duplicate_device(struct igt_device *dev) {
>  	return dup;
>  }
>  
> -static gint devs_compare(const void *a, const void *b)
> +static int devs_compare(const void *a, const void *b)

Could you squash this into patch 15/15? This way it will not be
needed as in there you remove glib in favour of igt_map.

Regards,
Kamil

>  {
>  	struct igt_device *dev1, *dev2;
>  	int ret;
> -- 
> 2.34.1
> 


More information about the igt-dev mailing list