[PATCH 1/3] tests/intel/xe_exec_system_allocator: Test to validate basic SVM functionality

[Ch, Sai Gowtham]

>-----Original Message-----
>From: Brost, Matthew <matthew.brost at intel.com>
>Sent: Thursday, May 15, 2025 4:41 AM
>To: Ch, Sai Gowtham <sai.gowtham.ch at intel.com>
>Cc: igt-dev at lists.freedesktop.org; Ghimiray, Himal Prasad
><himal.prasad.ghimiray at intel.com>; Cavitt, Jonathan <jonathan.cavitt at intel.com>
>Subject: Re: [PATCH 1/3] tests/intel/xe_exec_system_allocator: Test to validate
>basic SVM functionality
>
>On Wed, May 14, 2025 at 08:57:59PM +0000, sai.gowtham.ch at intel.com wrote:
>> From: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
>>
>> Basic test validates basic SVM functionality.
>>
>> Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray at intel.com>
>> Cc: Matthew Brost <matthew.brost at intel.com>
>> Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
>> Reviewed-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
>
>See my replies to rev1, to be clear I'm nacking all of this series.
>Please see my comments in rev1.

Thanks your review comments looks like rev2 was already in the mailing list before your comments on rev1,  Missed your comments.
Will have a look at it. 

Thanks,
Gowtham
>
>Matt
>
>> ---
>>  tests/intel/xe_exec_system_allocator.c | 63
>> ++++++++++++++++++++++++++
>>  1 file changed, 63 insertions(+)
>>
>> diff --git a/tests/intel/xe_exec_system_allocator.c
>> b/tests/intel/xe_exec_system_allocator.c
>> index 06daac8c2..68bf29898 100644
>> --- a/tests/intel/xe_exec_system_allocator.c
>> +++ b/tests/intel/xe_exec_system_allocator.c
>> @@ -32,6 +32,8 @@
>>  struct batch_data {
>>  	uint32_t batch[16];
>>  	uint64_t pad;
>> +	uint64_t vm_sync;
>> +	uint64_t exec_sync;
>>  	uint32_t data;
>>  	uint32_t expected_data;
>>  };
>> @@ -405,6 +407,63 @@ static void __aligned_partial_free(struct
>aligned_alloc_type  *aligned_alloc_typ
>>  		       aligned_alloc_type->__size - aligned_alloc_type->size -
>> begin_size);  }
>>
>> +/**
>> + * SUBTEST: basic-svm
>> + * Description: Test validates basic svm.
>> + * Test category: functionality test
>> + */
>> +static void test_basic(int fd, struct drm_xe_engine_class_instance *eci,
>> +		       size_t bo_size, int num_dwords) {
>> +	uint64_t addr;
>> +	struct drm_xe_sync sync[1] = {
>> +		{ .type = DRM_XE_SYNC_TYPE_USER_FENCE, .flags =
>DRM_XE_SYNC_FLAG_SIGNAL,
>> +		  .timeline_value = USER_FENCE_VALUE },
>> +	};
>> +	struct drm_xe_exec exec = {
>> +		.num_batch_buffer = 1,
>> +		.num_syncs = 1,
>> +		.syncs = to_user_pointer(sync),
>> +	};
>> +	struct batch_data *data;
>> +	uint32_t exec_queues, vm;
>> +	size_t aligned_size = bo_size ?: xe_get_default_alignment(fd);
>> +
>> +	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_FLAG_LR_MODE |
>DRM_XE_VM_CREATE_FLAG_FAULT_MODE, 0);
>> +	data = aligned_alloc(aligned_size, bo_size);
>> +	igt_assert(data != NULL);
>> +	memset(data, 0, bo_size);
>> +
>> +	exec_queues = xe_exec_queue_create(fd, vm, eci, 0);
>> +	sync[0].addr = to_user_pointer(&data[0].vm_sync);
>> +	bind_system_allocator(sync, 1);
>> +	xe_wait_ufence(fd, &data[0].vm_sync, USER_FENCE_VALUE, 0,
>NSEC_PER_SEC);
>> +	data[0].vm_sync = 0;
>> +
>> +	addr = to_user_pointer(data);
>> +	for (int i = 0; i <= num_dwords; i++) {
>> +		uint64_t batch_offset = (char *)&data[i].batch - (char *)data;
>> +		uint64_t batch_addr = addr + batch_offset;
>> +		uint64_t sdi_offset = (char *)&(data[i].data) - (char *)data;
>> +		uint64_t sdi_addr = addr + sdi_offset;
>> +		int b = 0;
>> +
>> +		write_dword(data[i].batch, sdi_addr, WRITE_VALUE(&data[i], i),
>&b);
>> +		igt_assert(b <= ARRAY_SIZE(data[i].batch));
>> +
>> +		exec.exec_queue_id = exec_queues;
>> +		exec.address = batch_addr;
>> +		sync[0].addr = addr + (char *)&data[i].exec_sync - (char *)data;
>> +		xe_exec(fd, &exec);
>> +		xe_wait_ufence(fd, &data[i].exec_sync, USER_FENCE_VALUE,
>exec_queues, NSEC_PER_SEC);
>> +		data[i].exec_sync = 0;
>> +		igt_assert_eq(data[i].data, READ_VALUE(&data[i]));
>> +	}
>> +	unbind_system_allocator();
>> +	free(data);
>> +	xe_exec_queue_destroy(fd, exec_queues);
>> +	xe_vm_destroy(fd, vm);
>> +}
>>  /**
>>   * SUBTEST: unaligned-alloc
>>   * Description: allocate unaligned sizes of memory @@ -1700,6
>> +1759,10 @@ igt_main
>>  		open_sync_file();
>>  	}
>>
>> +	igt_subtest("basic-svm")
>> +		xe_for_each_engine(fd, hwe)
>> +			test_basic(fd, hwe, SZ_64K, 1);
>> +
>>  	for (const struct section *s = sections; s->name; s++) {
>>  		igt_subtest_f("once-%s", s->name)
>>  			xe_for_each_engine(fd, hwe)
>> --
>> 2.34.1
>>