[PATCH v9 4/4] tests/kms_async_flips: Remove allow_fail flag from async flip tests

Santhosh Reddy Guddati santhosh.reddy.guddati at intel.com
Tue May 20 06:31:23 UTC 2025


Remove allow_fail flag as the async supported format modifiers are
now known to the user space. The test now executes for all supported
format modifiers.

V2: Remove check for frame 1, as no longer needed now as valid
    modifiers are being in use. (Chaitanya)

Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati at intel.com>
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah at intel.com>
---
 tests/kms_async_flips.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c
index 44bc38c71..f824f60f9 100644
--- a/tests/kms_async_flips.c
+++ b/tests/kms_async_flips.c
@@ -136,7 +136,6 @@ typedef struct {
 	enum pipe pipe;
 	bool alternate_sync_async;
 	bool suspend_resume;
-	bool allow_fail;
 	struct buf_ops *bops;
 	bool atomic_path;
 	bool overlay_path;
@@ -429,11 +428,7 @@ static void test_async_flip(data_t *data)
 		}
 
 		ret = perform_flip(data, frame, flags);
-
-		if (frame == 1 && data->allow_fail)
-			igt_skip_on(ret == -EINVAL);
-		else
-			igt_assert_eq(ret, 0);
+		igt_assert_eq(ret, 0);
 
 		wait_flip_event(data);
 
@@ -810,12 +805,6 @@ static void run_test(data_t *data, void (*test)(data_t *))
 			continue;
 
 		test_init(data);
-
-		if (data->linear_modifier && is_intel_device(data->drm_fd))
-			data->allow_fail = true;
-		else
-			data->allow_fail = false;
-
 		data->modifier = data->linear_modifier ? DRM_FORMAT_MOD_LINEAR : default_modifier(data);
 
 		igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(data->pipe), data->output->name) {
-- 
2.34.1



More information about the igt-dev mailing list