[PATCH i-g-t v10 5/5] tests/kms_async_flips: Skip Async Flips with Linear Modifier

[Borah, Chaitanya Kumar]

> -----Original Message-----
> From: Reddy Guddati, Santhosh <santhosh.reddy.guddati at intel.com>
> Sent: Wednesday, May 21, 2025 6:14 PM
> To: Borah, Chaitanya Kumar <chaitanya.kumar.borah at intel.com>; igt-
> dev at lists.freedesktop.org
> Cc: B S, Karthik <karthik.b.s at intel.com>; Murthy, Arun R
> <arun.r.murthy at intel.com>
> Subject: Re: [PATCH i-g-t v10 5/5] tests/kms_async_flips: Skip Async Flips with
> Linear Modifier
> 
> Hi Chaitanya,
> 
> On 21-05-2025 17:45, Borah, Chaitanya Kumar wrote:
> >
> >
> >> -----Original Message-----
> >> From: Reddy Guddati, Santhosh <santhosh.reddy.guddati at intel.com>
> >> Sent: Wednesday, May 21, 2025 4:23 PM
> >> To: igt-dev at lists.freedesktop.org
> >> Cc: B S, Karthik <karthik.b.s at intel.com>; Murthy, Arun R
> >> <arun.r.murthy at intel.com>; Borah, Chaitanya Kumar
> >> <chaitanya.kumar.borah at intel.com>; Reddy Guddati, Santhosh
> >> <santhosh.reddy.guddati at intel.com>
> >> Subject: [PATCH i-g-t v10 5/5] tests/kms_async_flips: Skip Async
> >> Flips with Linear Modifier
> >>
> >> Skip linear modifier async flip subtests on intel platforms with
> >> display version less than 12.
> >>
> >> Signed-off-by: Santhosh Reddy Guddati
> >> <santhosh.reddy.guddati at intel.com>
> >> ---
> >>   tests/kms_async_flips.c | 6 ++++++
> >>   1 file changed, 6 insertions(+)
> >>
> >> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c index
> >> f824f60f9..66dbbd5ab 100644
> >> --- a/tests/kms_async_flips.c
> >> +++ b/tests/kms_async_flips.c
> >> @@ -988,6 +988,9 @@ igt_main
> >>   		igt_describe("Wait for page flip events in between successive
> >> asynchronous "
> >>   			     "flips with linear modifiers");
> >>   		igt_subtest_with_dynamic("async-flip-with-page-flip-events-
> >> linear") {
> >> +			if (is_intel_device(data.drm_fd) &&
> >> +
> >> intel_display_ver(intel_get_drm_devid(data.drm_fd)) < 12)
> >> +				igt_skip("Async Flips with linear is not
> >> supported");
> >>   			test_init_ops(&data);
> >>   			data.linear_modifier = true;
> >>   			run_test(&data, test_async_flip); @@ -996,6 +999,9
> @@ igt_main
> >>   		igt_describe("Wait for page flip events in between successive
> >> asynchronous "
> >>   			     "flips using atomic path with linear modifiers");
> >>   		igt_subtest_with_dynamic("async-flip-with-page-flip-events-
> >> linear-atomic") {
> >> +			if (is_intel_device(data.drm_fd) &&
> >> +
> >> intel_display_ver(intel_get_drm_devid(data.drm_fd)) < 12)
> >> +				igt_skip("Async Flips with linear is not
> >> supported");
> >
> > Can't we use IN_FORMATS_ASYNC for this. Having this platform check
> defeats the purpose of the uapi.
> 
> The intent of this particular subtest is to test only the linear modifier and using
> IN_FORMAT_ASYNC , we have separate subtests to test the behaviour of tiled
> modifiers which were split in the below patch.
> 
> https://patchwork.freedesktop.org/patch/649872/?series=148182&rev=1

I understand that but we should check through IN_FORMAT_ASYNC if linear modifier is supported and forgo the platform check.

Regards

Chaitanya

> >
> > Regards
> >
> > Chaitanya
> >
> >>   			test_init_ops(&data);
> >>   			data.linear_modifier = true;
> >>   			run_test(&data, test_async_flip);
> >> --
> >> 2.34.1
> >