[PATCH i-g-t v9 12/14] tests/intel/xe_create: Conditionally define PAGE_SIZE for non-Android platforms

Kamil Konieczny kamil.konieczny at linux.intel.com
Thu May 22 11:36:37 UTC 2025


Hi Jeevaka,
On 2025-05-19 at 15:11:33 +0000, Jeevaka Prabu Badrappan wrote:
> Ensure PAGE_SIZE is defined only if it is not already defined,
> addressing compatibility with Android where PAGE_SIZE is predefined.
> 
> Note: PAGE_SIZE is defined in multiple files; a cleanup will be
> addressed in a future patch series.

I will drop this cleanup sentence before merge.
imho this could be done in one of xe headers (which every xe test
includes) and then fixing sources. Up to you.

> 
> Signed-off-by: Jeevaka Prabu Badrappan <jeevaka.badrappan at intel.com>
> Acked-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  tests/intel/xe_create.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/intel/xe_create.c b/tests/intel/xe_create.c
> index b22084c84..e8b8bb025 100644
> --- a/tests/intel/xe_create.c
> +++ b/tests/intel/xe_create.c
> @@ -18,7 +18,9 @@
>  #include "xe/xe_ioctl.h"
>  #include "xe/xe_query.h"
>  
> +#ifndef PAGE_SIZE
>  #define PAGE_SIZE 0x1000
> +#endif
>  
>  static struct param {
>  	unsigned int quantity;
> -- 
> 2.49.0
> 


More information about the igt-dev mailing list