[PATCH i-g-t] tests/intel/xe_eu_stall: Skip test on SR-IOV VF

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri May 23 10:47:40 UTC 2025


Hi Jakub,
On 2025-05-22 at 17:24:41 +0000, Jakub Kolakowski wrote:
> EU stall sampling is not supported on SR-IOV VF. Skip the test on SR-IOV
> VF.

imho better:
EU stall sampling is not supported on SR-IOV VF so add a skip for this.

> 
> Cc: Harish Chegondi <harish.chegondi at intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit at intel.com>
> Cc: Adam Miszczak <adam.miszczak at linux.intel.com>
> Cc: Lukasz Laguna <lukasz.laguna at intel.com>
> Cc: Marcin Bernatowicz <marcin.bernatowicz at linux.intel.com>
> Signed-off-by: Jakub Kolakowski <jakub1.kolakowski at intel.com>
> ---
>  tests/intel/xe_eu_stall.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/intel/xe_eu_stall.c b/tests/intel/xe_eu_stall.c
> index 411c30871..aa94d9565 100644
> --- a/tests/intel/xe_eu_stall.c
> +++ b/tests/intel/xe_eu_stall.c
> @@ -44,6 +44,7 @@
>  
>  #include "igt.h"
>  #include "igt_core.h"
> +#include "igt_sriov_device.h"
>  #include "xe_drm.h"
>  #include "xe/xe_ioctl.h"
>  
> @@ -653,7 +654,7 @@ igt_main_args("e:g:o:r:u:w:", long_options, help_str, opt_handler, NULL)
>  		drm_fd = drm_open_driver(DRIVER_XE);
>  		igt_require_fd(drm_fd);
>  		devid = intel_get_drm_devid(drm_fd);
> -		igt_require(IS_PONTEVECCHIO(devid) || intel_graphics_ver(devid) >= IP_VER(20, 0));
> +		igt_require(!intel_is_vf_device(drm_fd) && (IS_PONTEVECCHIO(devid) || intel_graphics_ver(devid) >= IP_VER(20, 0)));

Please add it as separate igt_require_f with clear skip message, like:

		igt_require_f(!intel_is_vf_device(drm_fd), "EU stall sampling not supported on SRIOV VF.\n");

imho you could keep Harish r-b.

Regards,
Kamil

>  		igt_require_f(igt_get_gpgpu_fillfunc(devid), "no gpgpu-fill function\n");
>  		igt_require_f(!stat(OBSERVATION_PARANOID, &sb), "no observation_paranoid file\n");
>  		if (output_file) {
> -- 
> 2.34.1
> 


More information about the igt-dev mailing list