[PATCH i-g-t v3 2/8] tests/amdgpu: fixup print/scan formatting for files in tests

Kamil Konieczny kamil.konieczny at linux.intel.com
Mon May 26 11:28:28 UTC 2025


Hi Jan,
On 2025-05-26 at 08:07:34 +0000, Jan Sokolowski wrote:
> Compiling on other architectures than x86-64 causes a lot
> of print/scan formatting warnings.
> 
> Fix formatting by using proper formatters, eg. PRIu64.
> 
> Signed-off-by: Jan Sokolowski <jan.sokolowski at intel.com>
> Cc: George Zhang <george.zhang at amd.com>
> Cc: Vitaly Prosyak <vitaly.prosyak at amd.com>

LGTM,
Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  tests/amdgpu/amd_freesync_video_mode.c | 4 ++--
>  tests/amdgpu/amd_info.c                | 2 +-
>  tests/amdgpu/amd_ras.c                 | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/amdgpu/amd_freesync_video_mode.c b/tests/amdgpu/amd_freesync_video_mode.c
> index 7716598dc..adfc8a810 100644
> --- a/tests/amdgpu/amd_freesync_video_mode.c
> +++ b/tests/amdgpu/amd_freesync_video_mode.c
> @@ -482,7 +482,7 @@ static int prepare_custom_mode(
>  	den = refresh_rate * 1000 * (unsigned long long)base_mode->htotal;
>  	target_vtotal = num / den;
>  	target_vtotal_diff = target_vtotal - base_mode->vtotal;
> -	igt_debug("num=%lu, den=%lu, target_vtotal=%lu, target_vtotal_diff=%lu, base_mode->vtotal=%d\n",
> +	igt_debug("num=%" PRIu64 ", den=%" PRIu64 ", target_vtotal=%" PRIu64 ", target_vtotal_diff=%" PRIu64 ", base_mode->vtotal=%d\n",
>  		num, den, target_vtotal, target_vtotal_diff, base_mode->vtotal);
>  
>  	/* Check for illegal modes */
> @@ -634,7 +634,7 @@ flip_and_measure(
>  	do_flip(data);
>  	start_ns = last_event_ns = target_ns = get_kernel_event_ns(data,
>  							DRM_EVENT_FLIP_COMPLETE);
> -	igt_debug("interval_ns=%lu\n", interval_ns);
> +	igt_debug("interval_ns=%" PRIu64 "\n", interval_ns);
>  
>  	for (;;) {
>  		uint64_t event_ns, wait_ns;
> diff --git a/tests/amdgpu/amd_info.c b/tests/amdgpu/amd_info.c
> index 53706003f..ace739da4 100644
> --- a/tests/amdgpu/amd_info.c
> +++ b/tests/amdgpu/amd_info.c
> @@ -73,7 +73,7 @@ query_timestamp_test(amdgpu_device_handle dev, uint32_t sleep_time, int sample_c
>  
>  		/* make sure the GPU timestamps are ordered */
>  		igt_assert_f(gpu_delta > 0,
> -			     "The GPU time is not moving or is ticking in the wrong direction (start=%lu, end=%lu, end-start=%lu)\n",
> +			     "The GPU time is not moving or is ticking in the wrong direction (start=%" PRIu64 ", end=%" PRIu64 ", end-start=%" PRIu64 "\n",
>  			     ts_start, ts_end, gpu_delta);
>  
>  		igt_stats_push_float(&stats, corrected_gpu_delta / cpu_delta);
> diff --git a/tests/amdgpu/amd_ras.c b/tests/amdgpu/amd_ras.c
> index c9307395a..fdf1bc27d 100644
> --- a/tests/amdgpu/amd_ras.c
> +++ b/tests/amdgpu/amd_ras.c
> @@ -765,7 +765,7 @@ __amdgpu_ras_ip_inject_test(struct amd_ras_single_test_setup *test,
>  			}
>  			timeout -= 1;
>  		}
> -		igt_info("\t%4s: test:%s block:%s sub-block:%d error type:%s address:%ld value:%ld\n",
> +		igt_info("\t%4s: test:%s block:%s sub-block:%d error type:%s address:%" PRIu64 " value:%" PRIu64 "\n",
>  				pass ? "Pass" : "Fail",
>  				ip_test[i].name,
>  				ip_test[i].block,
> -- 
> 2.34.1
> 


More information about the igt-dev mailing list