[PATCH i-g-t v12 5/5] tests/kms_async_flips: Skip Async Flips with Linear Modifier

[Borah, Chaitanya Kumar]

> -----Original Message-----
> From: Reddy Guddati, Santhosh <santhosh.reddy.guddati at intel.com>
> Sent: Tuesday, May 27, 2025 11:24 AM
> To: igt-dev at lists.freedesktop.org
> Cc: B S, Karthik <karthik.b.s at intel.com>; Murthy, Arun R
> <arun.r.murthy at intel.com>; Borah, Chaitanya Kumar
> <chaitanya.kumar.borah at intel.com>; Reddy Guddati, Santhosh
> <santhosh.reddy.guddati at intel.com>
> Subject: [PATCH i-g-t v12 5/5] tests/kms_async_flips: Skip Async Flips with
> Linear Modifier
> 
> Skip the linear modifier subtest on unsupported platforms
> 
> V2: Remove platform check and use in_formats_async (Chaitanya)
>     Update the commit message
> 
> V3: Fix crash
> 
> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati at intel.com>
> ---
>  tests/kms_async_flips.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c index
> f824f60f9..5aa05d039 100644
> --- a/tests/kms_async_flips.c
> +++ b/tests/kms_async_flips.c
> @@ -901,6 +901,22 @@ static void
> run_test_with_async_format_modifiers(data_t *data, void (*test)(data
>  	igt_vec_fini(&tested_formats);
>  }
> 
> +static bool is_linear_supported(data_t *data) {
> +	int i;

For drivers that don't support the IN_FORMATS_ASYNC property yet we should return true here. The assumption is that all modifiers are supported if the property is not defined.

> +
> +	for_each_pipe_with_valid_output(&data->display, data->pipe, data-
> >output) {
> +		test_init(data);
> +
> +		for (i = 0; i < data->plane->async_format_mod_count; i++) {
> +			if (data->plane->async_modifiers[i] ==
> DRM_FORMAT_MOD_LINEAR)
> +				return true;
> +		}
> +	}
> +
> +	return false;
> +}
> +
>  static void run_test_with_modifiers(data_t *data, void (*test)(data_t *))  {
>  	if (data->atomic_path)
> @@ -988,6 +1004,8 @@ igt_main
>  		igt_describe("Wait for page flip events in between successive
> asynchronous "
>  			     "flips with linear modifiers");
>  		igt_subtest_with_dynamic("async-flip-with-page-flip-events-
> linear") {
> +			igt_skip_on_f(!is_linear_supported(&data),
> +						  "Async Flips with linear
> modifier are not supported");
>  			test_init_ops(&data);
>  			data.linear_modifier = true;
>  			run_test(&data, test_async_flip);
> @@ -996,6 +1014,8 @@ igt_main
>  		igt_describe("Wait for page flip events in between successive
> asynchronous "
>  			     "flips using atomic path with linear modifiers");
>  		igt_subtest_with_dynamic("async-flip-with-page-flip-events-
> linear-atomic") {
> +			igt_skip_on_f(!is_linear_supported(&data),
> +						  "Async Flips with linear
> modifier are not supported");
>  			test_init_ops(&data);
>  			data.linear_modifier = true;
>  			run_test(&data, test_async_flip);
> --
> 2.34.1