[PATCH i-g-t] tests/intel/xe_fault_injection: Fix typo error tab

Dong, Zhanjun zhanjun.dong at intel.com
Thu May 29 16:05:03 UTC 2025



On 2025-05-29 8:25 a.m., Kamil Konieczny wrote:
> Hi Zhanjun,
> On 2025-05-28 at 10:14:54 -0400, Zhanjun Dong wrote:
>> Fix typo error <Tab> to <Space>.
>>
>> Signed-off-by: Zhanjun Dong <zhanjun.dong at intel.com>
>> ---
>>   tests/intel/xe_fault_injection.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/intel/xe_fault_injection.c b/tests/intel/xe_fault_injection.c
>> index f9bd5c761..9fe6bfe35 100644
>> --- a/tests/intel/xe_fault_injection.c
>> +++ b/tests/intel/xe_fault_injection.c
>> @@ -83,8 +83,8 @@ static void ignore_faults_in_dmesg(const char function_name[])
>>   	if (function_is_part_of_guc(function_name)) {
>>   		strcat(regex, "|GT[0-9a-fA-F]*: GuC init failed with -ENOMEM");
>>   		strcat(regex, "|GT[0-9a-fA-F]*: Failed to initialize uC .-ENOMEM");
>> -		strcat(regex, "|GT[0-9a-fA-F]*: Failed to enable GuC CT	.-ENOMEM");
>> -		strcat(regex, "|GT[0-9a-fA-F]*: GuC PC query task state failed:	-ENOMEM");
>> +		strcat(regex, "|GT[0-9a-fA-F]*: Failed to enable GuC CT .-ENOMEM");
>> +		strcat(regex, "|GT[0-9a-fA-F]*: GuC PC query task state failed: -ENOMEM");
>>   	}
> 
> Nice, maybe '\t' should be replaced with dot '.' in igt_core.c function
> so it will be ignored if someone in future will made similar error.
> 
> Regards,
> Kamil

Thanks Kamil for review this patch.
For these 2 messages, We already has one "." before -ENOMEM,
"Failed to enable GuC CT..-ENOMEM"
Normally 1 wildcard is safe, but put 2 wildcards together might cause 
unexpected matches, like
'Failed to enable GuC CTB(-ENOMEM)'
to be matched, if we have it in the future.
For now, I don't expect these 2 messages to be changed.

Regards,
Zhanjun Dong>
>>   
>>   	igt_emit_ignore_dmesg_regex(regex);
>> -- 
>> 2.34.1
>>



More information about the igt-dev mailing list