[PATCH i-g-t v2 2/4] tests/intel/xe_pmu: Add tests to validate engine activity on render node

[Umesh Nerlige Ramappa]

On Thu, May 29, 2025 at 12:23:57PM +0530, Riana Tauro wrote:
>Add idle, load and trailing idle tests to validate engine activity on
>render node
>
>Signed-off-by: Riana Tauro <riana.tauro at intel.com>
>---
> tests/intel/xe_pmu.c | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
>diff --git a/tests/intel/xe_pmu.c b/tests/intel/xe_pmu.c
>index 15b4b82d8..198470365 100644
>--- a/tests/intel/xe_pmu.c
>+++ b/tests/intel/xe_pmu.c
>@@ -53,6 +53,15 @@
>  * Description: Test to validate engine activity by running workload and trailing idle on all engines
>  * 		except one
>  *
>+ * SUBTEST: engine-activity-render-node-idle
>+ * Description: Test to validate engine activity on render node shows no load when idle
>+ *
>+ * SUBTEST: engine-activity-render-node-load
>+ * Description: Test to validate engine activity on render node by running workload
>+ *
>+ * SUBTEST: engine-activity-render-node-load-idle
>+ * Description: Test to validate engine activity on render node by running workload and trailing idle
>+ *
>  * SUBTEST: all-fn-engine-activity-load
>  * Description: Test to validate engine activity by running load on all functions simultaneously
>  *
>@@ -833,6 +842,30 @@ igt_main
> 		engine_activity_load_all(fd, num_engines, TEST_LOAD);
> 	}
>
>+	igt_subtest_group {
>+		int render_fd;
>+
>+		igt_fixture {
>+			render_fd = __drm_open_driver_render(DRIVER_XE);
>+			igt_require(render_fd);
>+		}
>+
>+		igt_describe("Validate engine activity on render node when idle");
>+		test_each_engine("engine-activity-render-node-idle", fd, eci)
>+			engine_activity(fd, eci, 0);
>+
>+		igt_describe("Validate engine activity on render node when loaded");
>+		test_each_engine("engine-activity-render-node-load", fd, eci)
>+			engine_activity(fd, eci, TEST_LOAD);
>+
>+		igt_describe("Validate engine activity on render node with load and trailing idle");
>+		test_each_engine("engine-activity-render-node-load-idle", fd, eci)
>+			engine_activity(fd, eci, TEST_LOAD | TEST_TRAILING_IDLE);

I think you need to pass render_fd in the above tests. They are still 
using fd.

>+
>+		igt_fixture
>+			drm_close_driver(render_fd);
>+	}
>+
> 	igt_subtest_group {
> 		unsigned int num_fns;
>
>-- 
>2.47.1
>