[PATCH i-g-t v2 3/4] tests/intel/xe_pmu: Add a test to validate engine activity after starting load

[Umesh Nerlige Ramappa]

On Thu, May 29, 2025 at 12:23:58PM +0530, Riana Tauro wrote:
>Add a test to validate engine activity by opening PMU after
>starting load
>
>Signed-off-by: Riana Tauro <riana.tauro at intel.com>

LGTM,

Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>

Thanks,
Umesh
>---
> tests/intel/xe_pmu.c | 47 ++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 47 insertions(+)
>
>diff --git a/tests/intel/xe_pmu.c b/tests/intel/xe_pmu.c
>index 198470365..21b294167 100644
>--- a/tests/intel/xe_pmu.c
>+++ b/tests/intel/xe_pmu.c
>@@ -46,6 +46,9 @@
>  * SUBTEST: engine-activity-suspend
>  * Description: Test to validate engine activity on all engines before and after s2idle
>  *
>+ * SUBTEST: engine-activity-after-load-start
>+ * Description: Validates engine activity when PMU is opened after load started
>+ *
>  * SUBTEST: engine-activity-most-load
>  * Description: Test to validate engine activity by running workload on all engines except one
>  *
>@@ -569,6 +572,46 @@ static void engine_activity_fn(int fd, struct drm_xe_engine_class_instance *eci,
> 		assert_within_epsilon(busy_percent, exec_quantum_ratio, tolerance);
> }
>
>+static void engine_activity_load_start(int fd, struct drm_xe_engine_class_instance *eci)
>+{
>+	uint64_t ahnd, config, engine_active_ticks, engine_total_ticks, before[2], after[2];
>+	struct xe_cork *cork = NULL;
>+	uint32_t vm;
>+	int pmu_fd[2];
>+
>+	vm = xe_vm_create(fd, 0, 0);
>+	ahnd = intel_allocator_open(fd, 0, INTEL_ALLOCATOR_RELOC);
>+	cork = xe_cork_create_opts(fd, eci, vm, 1, 1, .ahnd = ahnd);
>+	xe_cork_sync_start(fd, cork);
>+
>+	config = get_event_config(eci->gt_id, eci, "engine-active-ticks");
>+	pmu_fd[0] = open_group(fd, config, -1);
>+
>+	config = get_event_config(eci->gt_id, eci, "engine-total-ticks");
>+	pmu_fd[1] = open_group(fd, config, pmu_fd[0]);
>+
>+	pmu_read_multi(pmu_fd[0], 2, before);
>+	usleep(SLEEP_DURATION * USEC_PER_SEC);
>+	pmu_read_multi(pmu_fd[0], 2, after);
>+	end_cork(fd, cork);
>+
>+	engine_active_ticks = after[0] - before[0];
>+	engine_total_ticks = after[1] - before[1];
>+
>+	igt_debug("Engine active ticks:  after %ld, before %ld delta %ld\n", after[0], before[0],
>+		  engine_active_ticks);
>+	igt_debug("Engine total ticks: after %ld, before %ld delta %ld\n", after[1], before[1],
>+		  engine_total_ticks);
>+
>+	xe_cork_destroy(fd, cork);
>+	xe_vm_destroy(fd, vm);
>+	put_ahnd(ahnd);
>+	close(pmu_fd[0]);
>+	close(pmu_fd[1]);
>+
>+	assert_within_epsilon(engine_active_ticks, engine_total_ticks, tolerance);
>+}
>+
> static void test_gt_c6_idle(int xe, unsigned int gt)
> {
> 	int pmu_fd;
>@@ -842,6 +885,10 @@ igt_main
> 		engine_activity_load_all(fd, num_engines, TEST_LOAD);
> 	}
>
>+	igt_describe("Validate engine activity when PMU is opened after load");
>+	test_each_engine("engine-activity-after-load-start", fd, eci)
>+		engine_activity_load_start(fd, eci);
>+
> 	igt_subtest_group {
> 		int render_fd;
>
>-- 
>2.47.1
>