[PATCH i-g-t] tests/intel/xe_fault_injection: Ignore all errors while injecting fault

Michal Wajdeczko michal.wajdeczko at intel.com
Thu May 29 20:29:23 UTC 2025



On 29.05.2025 18:23, Daniele Ceraolo Spurio wrote:
> 
> 
> On 5/29/2025 6:31 AM, Satyanarayana K V P wrote:
>> Currently, numerous fault messages have been included in the dmesg
>> ignore list,
>> and this list continues to expand. Each time a new fault injection
>> point is
>> introduced or a new feature is activated, additional fault messages
>> appear,
>> making it cumbersome to manage the dmesg ignore list.
>>
>> This new patch automatically ignores all error messages from dmesg,
>> eliminating
>> the need to add or maintain a dmesg ignore message list.
> 
> This would make the test almost meaningless. If the test finds an actual
> bug (i.e., an error we didn't expect), how would CI detect and report it

but how can you tell upfront, without actually running a test, which
error is expected and which is not?

> if all errors are ignored? The only situations we would still fail on is
> when the kernel just dies.

and that perfectly fins, sine we should look only for BUG and WARNs, as
it's quite natural and expected that once we inject an error, the driver
will likely fail to load or proceed, and/or may report some error
messages, or even try to silently recover, *but* it shouldn't ever crash

and that should be taken as a test goal, not that we look for specific
error messages that could be changed, omitted, replaced by the different
driver release or when running on different platform or function

Michal

> 
> Daniele
> 


More information about the igt-dev mailing list