<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 05-05-2020 18:50, Anshuman Gupta
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20200505132032.827-5-anshuman.gupta@intel.com">
<pre class="moz-quote-pre" wrap="">screens-disabled test is only valid for the plaforms like HSW/BDW
where PG1 is Always-ON power domain, so these platform test lpsp
with all screen disabled i.e validate PG2 when all screen are
disabled.
DC state i.e DMC f/w supported platforms don't have any ROI to validate
screen-disabled subtest as existing dc*-dpms i915_pm_dc subtest
already validate it implicitly.
This should save some CI-Cycles.
Signed-off-by: Anshuman Gupta <a class="moz-txt-link-rfc2396E" href="mailto:anshuman.gupta@intel.com"><anshuman.gupta@intel.com></a>
---
tests/i915/i915_pm_lpsp.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
index 8d2e23fe..56980de2 100644
--- a/tests/i915/i915_pm_lpsp.c
+++ b/tests/i915/i915_pm_lpsp.c
@@ -172,8 +172,11 @@ igt_main
}
igt_describe("This test validates lpsp while all crtc are disabled");
- igt_subtest("screens-disabled")
+ igt_subtest("screens-disabled") {
+ igt_skip_on_f(openat(data.debugfs_fd, "i915_dmc_info", O_RDONLY) > 0,
+ "DC states supported platform don't have ROI for this subtest\n");
screens_disabled_subtest(&data);
+ }</pre>
</blockquote>
<pre>I agree from gen9 onward dmc support is present and same time we have multiple power-well having different pipe.
To avoid platform specific change I feel ok to check dmc info. Changes looks good to me.
Can you please club together the changes of this patch with previous one (3/6) where screens_disabled_subtest is implemented to give a better clarity on which platform it is targeted for.
Regards,
Animesh
</pre>
<blockquote type="cite"
cite="mid:20200505132032.827-5-anshuman.gupta@intel.com">
<pre class="moz-quote-pre" wrap="">
igt_describe("This test validates lpsp on all connected outputs on low power PIPE_A");
igt_subtest_with_dynamic_f("kms-lpsp") {
</pre>
</blockquote>
</body>
</html>