<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 16-07-2020 19:45, Anshuman Gupta
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20200716141557.15909-1-anshuman.gupta@intel.com">
<pre class="moz-quote-pre" wrap="">Sometimes LPSP test may fail due to HOTPLUG events,
which initiates AUX transaction in order to detect a Connector
status, these ongoing AUX transaction may fail the LPSP igt test.
Adding a igt_wait will avoid such failures.
Some eDP panel may have power_cycle_delay of 600ms,
therefore 1sec delay is safer.
Cc: Animesh Manna <a class="moz-txt-link-rfc2396E" href="mailto:animesh.manna@intel.com"><animesh.manna@intel.com></a>
Signed-off-by: Anshuman Gupta <a class="moz-txt-link-rfc2396E" href="mailto:anshuman.gupta@intel.com"><anshuman.gupta@intel.com></a></pre>
</blockquote>
<pre>LGTM.
Reviewed-by: Animesh Manna <a class="moz-txt-link-rfc2396E" href="mailto:animesh.manna@intel.com"><animesh.manna@intel.com></a>
</pre>
<blockquote type="cite"
cite="mid:20200716141557.15909-1-anshuman.gupta@intel.com">
<pre class="moz-quote-pre" wrap="">
---
tests/i915/i915_pm_lpsp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
index 12670f22..e9a59307 100644
--- a/tests/i915/i915_pm_lpsp.c
+++ b/tests/i915/i915_pm_lpsp.c
@@ -163,7 +163,8 @@ static void test_lpsp(data_t *data)
data->mode->vdisplay <= 2160);
setup_lpsp_output(data);
- igt_assert_f(lpsp_is_enabled(data), "%s: lpsp is not enabled\n%s:\n%s\n",
+ igt_assert_f(igt_wait(lpsp_is_enabled(data), 1000, 100),
+ "%s: lpsp is not enabled\n%s:\n%s\n",
data->output->name, PWR_DOMAIN_INFO, data->pwr_dmn_info =
igt_sysfs_get(data->debugfs_fd, PWR_DOMAIN_INFO));
}
</pre>
</blockquote>
</body>
</html>