<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
This series looks good to me, and I tested it on our internal CI with our hardware.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Series is:</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Reviewed-By: Nicholas Choi <Nicholas.Choi@amd.com></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks.<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com><br>
<b>Sent:</b> Wednesday, August 25, 2021 10:36 AM<br>
<b>To:</b> igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org><br>
<b>Cc:</b> abhinavk@codeaurora.org <abhinavk@codeaurora.org>; Wentland, Harry <Harry.Wentland@amd.com>; Choi, Nicholas <Nicholas.Choi@amd.com>; Sean Paul <seanpaul@chromium.org>; Mark Yacoub <markyacoub@chromium.org>; Melissa Wen <melissa.srw@gmail.com>; Arkadiusz
Hiler <arek@hiler.eu>; Petri Latvala <petri.latvala@intel.com><br>
<b>Subject:</b> [PATCH v2 0/4] Make kms_concurrent, transition, and atomic generic</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">This series target three KMS tests:<br>
<br>
1. kms_concurrent<br>
2. kms_transition<br>
3. kms_atomic<br>
<br>
All of these tests fail in the amdgpu or the VKMS drivers. After<br>
debugging the issue, I realize that we need to make these tests generic<br>
for other drivers, and we also need minor fixes to enable it for<br>
different devices. Mark submitted the first patch of this series a long<br>
time ago; I just update the commit message and rebase it in the latest<br>
code. The patch associate with kms_concurrent makes it generic enough to<br>
run in VKMS and VC4. Finally, for the kms_atomic I added a bug fix, and<br>
I also skip one test that does not apply to amdgpu.<br>
<br>
Change since V1:<br>
- Use DRM_FORMAT_MOD_LINEAR instead of DRM_FORMAT_MOD_NONE<br>
- Improve skip message<br>
- Rebase<br>
- Test on VC4<br>
<br>
Thanks<br>
Siqueira<br>
<br>
Cc: Harry Wentland <harry.wentland@amd.com><br>
Cc: Nicholas Choi <Nicholas.Choi@amd.com><br>
Cc: Sean Paul <seanpaul@chromium.org><br>
Cc: Mark Yacoub <markyacoub@chromium.org><br>
Cc: Melissa Wen <melissa.srw@gmail.com><br>
Cc: Arkadiusz Hiler <arek@hiler.eu><br>
Cc: Petri Latvala <petri.latvala@intel.com><br>
<br>
Mark Yacoub (1):<br>
tests/kms_atomic_transition: Enable Primary Plane on Enabling CRTC<br>
<br>
Rodrigo Siqueira (3):<br>
tests/kms_concurrent: Making the test more generic<br>
tests/kms_atomic: Initialize array values before checking them<br>
test/kms_atomic: Skip plane overlay test for amdgpu<br>
<br>
tests/kms_atomic.c | 9 +++++++++<br>
tests/kms_atomic_transition.c | 6 +++---<br>
tests/kms_concurrent.c | 27 ++++++++++++++-------------<br>
3 files changed, 26 insertions(+), 16 deletions(-)<br>
<br>
-- <br>
2.25.1<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>