<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi <font size="2"><span style="font-size:11pt">Rodrigo Siqueira</span></font>,<br>
</div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Thanks for your reviewing.</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
I only sent the patch one time by git send-email, I don't know where does the V2 come from.</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Thanks,</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Rico<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com><br>
<b>Sent:</b> Thursday, August 26, 2021 20:36<br>
<b>To:</b> Yin, Tianci (Rico) <Tianci.Yin@amd.com><br>
<b>Cc:</b> igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org>; Petri Latvala <petri.latvala@intel.com>; Arkadiusz Hiler <arek@hiler.eu>; Mark Yacoub <markyacoub@google.com>; Wentland, Harry <Harry.Wentland@amd.com>; Choi, Nicholas <Nicholas.Choi@amd.com><br>
<b>Subject:</b> Re: [PATCH] tests/kms_atomic_interruptible: fix a warning message on AMD GPU</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">On 08/25, Tianci Yin wrote:<br>
> From: "Tianci.Yin" <tianci.yin@amd.com><br>
> <br>
> [why]<br>
> For subtest legacy-setmode and atomic-setmode, fb buffer is<br>
> unbinded from plane by block_plane(), then igt_display_commit2()<br>
> will trigger a dmesg warning message in drm_atomic_helper_commit(),<br>
> since for block commit, drm will wait fences that represents<br>
> finishing fb writing, when it find this fence has no accompanying<br>
> fb, it gives out a warning.<br>
> <br>
> [how]<br>
> Just remove igt_plane_set_fb() from block_plane() to retain<br>
> the fb binding with plane.<br>
> Verified on AMD Radeon Pro W5500 and Intel UHD Graphics 630<br>
> (inside i7-9700K), both pass.<br>
> <br>
> Signed-off-by: Tianci.Yin <tianci.yin@amd.com><br>
> ---<br>
> tests/kms_atomic_interruptible.c | 1 -<br>
> 1 file changed, 1 deletion(-)<br>
> <br>
> diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c<br>
> index 0a127921..03980d6e 100644<br>
> --- a/tests/kms_atomic_interruptible.c<br>
> +++ b/tests/kms_atomic_interruptible.c<br>
> @@ -49,7 +49,6 @@ static int block_plane(igt_display_t *display, igt_output_t *output, enum plane_<br>
> <br>
> if (test_type == test_legacy_modeset || test_type == test_atomic_modeset) {<br>
> igt_output_set_pipe(output, PIPE_NONE);<br>
> - igt_plane_set_fb(plane, NULL);<br>
> }<br>
> igt_plane_set_fence_fd(plane, sw_sync_timeline_create_fence(timeline, 1));<br>
> <br>
> -- <br>
> 2.25.1<br>
><br>
<br>
Btw, did you submit a V2?<br>
<br>
If so, it looks like that there is a merge problem in the new version, see:<br>
<br>
<a href="https://patchwork.freedesktop.org/series/94006/#rev2">https://patchwork.freedesktop.org/series/94006/#rev2</a>
<br>
<br>
Thanks<br>
<br>
-- <br>
Rodrigo Siqueira<br>
<a href="https://siqueira.tech">https://siqueira.tech</a><br>
</div>
</span></font></div>
</div>
</body>
</html>