<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
Sure, that makes sense. Will send a v2<br>
</div>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="Signature">
<div>
<div></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
--</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Jay<br>
</div>
</div>
</div>
</div>
<div id="appendonsend"></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size: 11pt;" face="Calibri, sans-serif" color="#000000"><b>From:</b> Mark Yacoub <markyacoub@chromium.org><br>
<b>Sent:</b> Monday, September 27, 2021 3:12 PM<br>
<b>To:</b> Pillai, Aurabindo <Aurabindo.Pillai@amd.com><br>
<b>Cc:</b> Development mailing list for IGT GPU Tools <igt-dev@lists.freedesktop.org>; Mark Yacoub <markyacoub@google.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com><br>
<b>Subject:</b> Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">I'm not 100% sure but personally if I'm running the test on an AMD<br>
device, I don't really care about seeing a subtest that I'm not<br>
interested in.<br>
<br>
On Mon, Sep 27, 2021 at 3:10 PM Pillai, Aurabindo<br>
<Aurabindo.Pillai@amd.com> wrote:<br>
><br>
> [AMD Official Use Only]<br>
><br>
><br>
> Skipping using the continue statement has the side effect of this subtest being absent from the list of subtests, when running the test executable with paramter --list-subtest. Is that okay ?<br>
><br>
> --<br>
><br>
> Regards,<br>
> Jay<br>
> ________________________________<br>
> From: Mark Yacoub <markyacoub@chromium.org><br>
> Sent: Monday, September 27, 2021 1:34 PM<br>
> To: Pillai, Aurabindo <Aurabindo.Pillai@amd.com><br>
> Cc: Development mailing list for IGT GPU Tools <igt-dev@lists.freedesktop.org>; Mark Yacoub <markyacoub@google.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com><br>
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big<br>
><br>
> so for the sake of consistency, I'm wondering if we can skip the test<br>
> the same way we skip other tests such as<br>
> ```<br>
> if (tests[i].flags & TEST_NO_2X_OUTPUT)<br>
> continue;<br>
> ```<br>
> because we're not failing a certain condition but a whole test, it<br>
> might be better not to run the test in the first place unless it's<br>
> intel.<br>
> So in both main loops that call run_test we can do if<br>
> if (tests[i].flags & TEST_BO_TOOBIG && !intel)<br>
> continue;<br>
> this way we're not too worried where the flag would be used across the<br>
> test and not skip halfway through a test.<br>
><br>
> On Mon, Sep 27, 2021 at 1:28 PM Pillai, Aurabindo<br>
> <Aurabindo.Pillai@amd.com> wrote:<br>
> ><br>
> > [AMD Official Use Only]<br>
> ><br>
> ><br>
> > Hi Mark,<br>
> ><br>
> ><br>
> > Both bo-too-big and bo-too-big-interruptible shall be skipped with this patch. The other location where TEST_BO_TOOBIG is mentioned is in the same function.<br>
> ><br>
> > --<br>
> ><br>
> > Regards,<br>
> > Jay<br>
> > ________________________________<br>
> > From: Mark Yacoub <markyacoub@chromium.org><br>
> > Sent: Monday, September 27, 2021 1:21 PM<br>
> > To: Pillai, Aurabindo <Aurabindo.Pillai@amd.com><br>
> > Cc: Development mailing list for IGT GPU Tools <igt-dev@lists.freedesktop.org>; Mark Yacoub <markyacoub@google.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com><br>
> > Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big<br>
> ><br>
> > On Mon, Sep 27, 2021 at 12:07 PM Aurabindo Pillai<br>
> > <aurabindo.pillai@amd.com> wrote:<br>
> > ><br>
> > > [Why]<br>
> > > The rationale of the test does not hold true for AMD hardware. The<br>
> > > aperture size calculation has an upper bound check which is done through<br>
> > > i915 specific IOCTL. Hence this part of subtest must be moved<br>
> > > out of the platform agnostic tests. Moreover, AMD hardware<br>
> > > supports buffers larger than aperture size.<br>
> > ><br>
> > > [How]<br>
> > > Skip the bo-too-big subtest unless its run on i915 as the test fails on<br>
> > > AMD, VKMS and VC4<br>
> > ><br>
> > > Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com><br>
> > > ---<br>
> > > tests/kms_flip.c | 1 +<br>
> > > 1 file changed, 1 insertion(+)<br>
> > ><br>
> > > diff --git a/tests/kms_flip.c b/tests/kms_flip.c<br>
> > > index 54137871..20112de1 100755<br>
> > > --- a/tests/kms_flip.c<br>
> > > +++ b/tests/kms_flip.c<br>
> > > @@ -1290,6 +1290,7 @@ static void __run_test_on_crtc_set(struct test_output *o, int *crtc_idxs,<br>
> > > /* 256 MB is usually the maximum mappable aperture,<br>
> > > * (make it 4x times that to ensure failure) */<br>
> > > if (o->flags & TEST_BO_TOOBIG) {<br>
> > There is also another place where TEST_BO_TOOBIG is used, should we<br>
> > skip this one as well or it's only this part?<br>
> > > + igt_skip_on(!is_i915_device(drm_fd));<br>
> > > bo_size = 4*gem_mappable_aperture_size(drm_fd);<br>
> > > igt_require(bo_size < gem_global_aperture_size(drm_fd));<br>
> > > }<br>
> > > --<br>
> > > 2.30.2<br>
> > ><br>
</div>
</span></font></div>
</div>
</body>
</html>