<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I don't have the commits in front of me, but there was an issue with the port from amd_hdr to kms_hdr where the test would do a TEST_ONLY commit that change the output bpc to 10 but then the debugfs check
<i>after </i>would try and verify that the output bpc was 10 - which doesn't work if the output bpc was previously 8 because the commit wasn't actually applied.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Nicholas Kazlauskas</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Simon Ser <contact@emersion.fr><br>
<b>Sent:</b> Thursday, October 7, 2021 10:49 AM<br>
<b>To:</b> Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com><br>
<b>Cc:</b> Saarinen, Jani <jani.saarinen@intel.com>; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>; Latvala, Petri <petri.latvala@intel.com>; Wang, Chao-kai (Stylon) <Stylon.Wang@amd.com>; igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org>;
Choi, Nicholas <Nicholas.Choi@amd.com>; Mark Yacoub <markyacoub@google.com>; Wentland, Harry <Harry.Wentland@amd.com>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com><br>
<b>Subject:</b> Re: [PATCH i-g-t] tests/kms_hdr: Fix failure to read output_bpc on AMD hardware</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">I don't think removing TEST_ONLY is correct? bafd90661c26 ("tests/kms_hdr: Add<br>
bpc switch subtests") reads:<br>
<br>
v4: -Plane size back to CRTC size, regression observed in hsw again<br>
"Plane must cover entire CRTC" because of plane size restriction<br>
to 512x512. Petri/Ville suggested to use TEST_ONLY in try_commit()<br>
to probe whether we can use a smaller than fullscreen plane.<br>
<br>
cc Nicholas<br>
</div>
</span></font></div>
</div>
</body>
</html>