<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
I wanna propose to break down this patch into 2 changes:</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<ol>
<li><span>Keep theTEST_ONLY commit to check if 512x512 plane works. If not, change the plane size to cover full CRTC.</span></li><li><span>Add a real commit after TEST_ONLY to set output bpc to 8. This should satisfy the first check that the output bpc is indeed 8</span></li></ol>
</div>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Regards</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="Signature">
<div>
<div></div>
<div></div>
<div></div>
<div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p style="margin-top:0px; margin-bottom:0px; margin-top:0; margin-bottom:0"></p>
<p style="margin:0in 0in 0.0001pt; font-size:11pt; font-family:Calibri,sans-serif; color:rgb(32,31,30); text-align:start; background-color:rgb(255,255,255)">
<span style="margin:0px; font-size:9pt; font-family:Arial,sans-serif; color:black"><u><b>Stylon Wang</b></u></span></p>
<p style="margin:0in 0in 0.0001pt; font-size:11pt; font-family:Calibri,sans-serif; color:rgb(32,31,30); text-align:start; background-color:rgb(255,255,255)">
<span style="margin:0px; font-size:9pt; font-family:Arial,sans-serif; color:black">MTS Software Development Eng. |<b> AMD</b><br>
Display Solution Team</span></p>
<p style="margin:0in 0in 0.0001pt; font-size:11pt; font-family:Calibri,sans-serif; color:rgb(32,31,30); text-align:start; background-color:rgb(255,255,255)">
<span style="margin:0px; font-size:9pt; font-family:Arial,sans-serif; color:black"><b style="color:rgb(32,31,30); font-family:Calibri,sans-serif; font-size:14.6667px; background-color:rgb(255,255,255)"><span style="margin:0px; font-size:9pt; font-family:Arial,sans-serif; color:black">O</span></b><span style="margin:0px; font-size:9pt; font-family:Arial,sans-serif; color:black; background-color:rgb(255,255,255)"> +(886)
2-3789-3667 ext. 23667 <b>C</b> +(886) 921-897-142</span><br>
</span></p>
<p style="margin:0in 0in 0.0001pt; font-size:11pt; font-family:Calibri,sans-serif; color:rgb(32,31,30); text-align:start; background-color:rgb(255,255,255)">
<b><span style="margin:0px; font-size:9pt; color:rgb(242,101,34); letter-spacing:-1.4pt">----------------------------------------------------------------------------------------------------------------------------------</span></b><b><span style="margin:0px; font-size:9pt; color:rgb(242,101,34)"></span></b></p>
<p style="margin:0in 0in 0.0001pt; font-size:11pt; font-family:Calibri,sans-serif; color:rgb(32,31,30); text-align:start; background-color:rgb(255,255,255)">
<span style="margin:0px; font-size:9pt; font-family:Arial,sans-serif; color:black"><span tabindex="0" style="margin:0px; padding:1px 0px; border-width:0px 0px 1px; border-bottom-style:dashed">6F, 3, YuanCyu St (NanKang Software Park) Taipei, Taiwan</span></span></p>
<p style="margin:0in 0in 0.0001pt; font-size:11pt; font-family:Calibri,sans-serif; color:rgb(32,31,30); text-align:start; background-color:rgb(255,255,255)">
<span style="margin:0px; font-size:9pt; font-family:Arial,sans-serif; color:black"><a href="https://www.facebook.com/AMD" target="_blank" rel="noopener noreferrer" style="margin:0px"><span style="margin:0px">Facebook</span></a> | <a href="https://twitter.com/AMD" target="_blank" rel="noopener noreferrer" style="margin:0px"><span style="margin:0px">Twitter</span></a> | <a href="http://www.amd.com/" target="_blank" rel="noopener noreferrer" style="margin:0px"><span style="margin:0px">amd.com</span></a></span><span style="margin:0px; font-size:10pt; font-family:Arial,sans-serif; color:black"> </span></p>
<p style="margin:0in 0in 0.0001pt; font-size:11pt; font-family:Calibri,sans-serif; color:rgb(32,31,30); text-align:start; background-color:rgb(255,255,255)">
</p>
<p style="margin-top:0px; margin-bottom:0px; margin-top:0; margin-bottom:0"></p>
</div>
</div>
</div>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com><br>
<b>Sent:</b> October 7, 2021 10:59 PM<br>
<b>To:</b> Wentland, Harry <Harry.Wentland@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Simon Ser <contact@emersion.fr><br>
<b>Cc:</b> Saarinen, Jani <jani.saarinen@intel.com>; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>; Latvala, Petri <petri.latvala@intel.com>; Wang, Chao-kai (Stylon) <Stylon.Wang@amd.com>; igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org>;
Choi, Nicholas <Nicholas.Choi@amd.com>; Mark Yacoub <markyacoub@google.com><br>
<b>Subject:</b> Re: [PATCH i-g-t] tests/kms_hdr: Fix failure to read output_bpc on AMD hardware</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On 2021-10-07 10:56 a.m., Harry Wentland wrote:<br>
> <br>
> <br>
> On 2021-10-07 10:54, Kazlauskas, Nicholas wrote:<br>
>> [AMD Official Use Only]<br>
>><br>
>><br>
>> I don't have the commits in front of me, but there was an issue with the port from amd_hdr to kms_hdr where the test would do a TEST_ONLY commit that change the output bpc to 10 but then the debugfs check /after /would try and verify that the output bpc
was 10 - which doesn't work if the output bpc was previously 8 because the commit wasn't actually applied.<br>
>><br>
> <br>
> <a href="https://patchwork.freedesktop.org/patch/456663/?series=95313&rev=1">https://patchwork.freedesktop.org/patch/456663/?series=95313&rev=1</a><br>
> <br>
> Stylon, is that what is happening?<br>
> <br>
> If so, please make sure the commit description reflects that. The existing<br>
> description doesn't explain why switching from TEST_ONLY to ALLOW_MODESET<br>
> fixes things.<br>
> <br>
> Harry<br>
<br>
Thanks for linking it - it looks like it's actually the reverse, where <br>
it tries to change bpc to 8 but the connector may not currently be in 8 <br>
nor is there a requirement for it to be before the test starts.<br>
<br>
Userspace might have already been running with an uncapped max bpc <br>
before the test starts.<br>
<br>
Regards,<br>
Nicholas Kazlauskas<br>
<br>
> <br>
> <br>
>> Regards,<br>
>> Nicholas Kazlauskas<br>
>> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------<br>
>> *From:* Simon Ser <contact@emersion.fr><br>
>> *Sent:* Thursday, October 7, 2021 10:49 AM<br>
>> *To:* Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com><br>
>> *Cc:* Saarinen, Jani <jani.saarinen@intel.com>; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>; Latvala, Petri <petri.latvala@intel.com>; Wang, Chao-kai (Stylon) <Stylon.Wang@amd.com>; igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org>;
Choi, Nicholas <Nicholas.Choi@amd.com>; Mark Yacoub <markyacoub@google.com>; Wentland, Harry <Harry.Wentland@amd.com>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com><br>
>> *Subject:* Re: [PATCH i-g-t] tests/kms_hdr: Fix failure to read output_bpc on AMD hardware<br>
>> <br>
>> I don't think removing TEST_ONLY is correct? bafd90661c26 ("tests/kms_hdr: Add<br>
>> bpc switch subtests") reads:<br>
>><br>
>> v4: -Plane size back to CRTC size, regression observed in hsw again<br>
>> "Plane must cover entire CRTC" because of plane size restriction<br>
>> to 512x512. Petri/Ville suggested to use TEST_ONLY in try_commit()<br>
>> to probe whether we can use a smaller than fullscreen plane.<br>
>><br>
>> cc Nicholas<br>
> <br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>