<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> Re-reported.<o:p></o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Wang, Chao-kai (Stylon) <Stylon.Wang@amd.com> Sent: Tuesday, October 12, 2021 10:57 PM To: Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; igt-dev@lists.freedesktop.org Cc: Choi, Nicholas <Nicholas.Choi@amd.com>; Wentland, Harry <Harry.Wentland@amd.com>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>; contact@emersion.fr Subject: Re: [PATCH i-g-t v2] tests/kms_hdr: Fix failure to read output_bpc<o:p></o:p> </div> </div> <o:p> </o:p> [AMD Official Use Only]<o:p></o:p> <o:p> </o:p> <div> <div> Hi Lakshminarayana,<o:p></o:p> </div> <div> <o:p> </o:p> </div> <div> Here it is: <a href="https://patchwork.freedesktop.org/series/95601/">https://patchwork.freedesktop.org/series/95601/</a><o:p></o:p> </div> <div> <div> <o:p> </o:p> </div> <div> <o:p> </o:p> </div> <div> Regards<o:p></o:p> </div> <div id="Signature"> <div> <div id="divtagdefaultwrapper"> Stylon Wang<o:p></o:p> MTS Software Development Eng. | AMD Display Solution Team<o:p></o:p> O +(886) 2-3789-3667 ext. 23667 C +(886) 921-897-142<o:p></o:p> ----------------------------------------------------------------------------------------------------------------------------------<o:p></o:p> 6F, 3, YuanCyu St (NanKang Software Park) Taipei, Taiwan<o:p></o:p> <a href="https://www.facebook.com/AMD" target="_blank">Facebook</a> | <a href="https://twitter.com/AMD" target="_blank">Twitter</a> | <a href="http://www.amd.com/" target="_blank">amd.com</a> <o:p></o:p> <o:p></o:p> </div> </div> </div> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> From: Vudum, Lakshminarayana <<a href="mailto:lakshminarayana.vudum@intel.com">lakshminarayana.vudum@intel.com</a>> Sent: October 9, 2021 5:04 AM To: Siqueira, Rodrigo <<a href="mailto:Rodrigo.Siqueira@amd.com">Rodrigo.Siqueira@amd.com</a>>; <a href="mailto:igt-dev@lists.freedesktop.org">igt-dev@lists.freedesktop.org</a> <<a href="mailto:igt-dev@lists.freedesktop.org">igt-dev@lists.freedesktop.org</a>> Cc: Choi, Nicholas <<a href="mailto:Nicholas.Choi@amd.com">Nicholas.Choi@amd.com</a>>; Wentland, Harry <<a href="mailto:Harry.Wentland@amd.com">Harry.Wentland@amd.com</a>>; Kazlauskas, Nicholas <<a href="mailto:Nicholas.Kazlauskas@amd.com">Nicholas.Kazlauskas@amd.com</a>>; Siqueira, Rodrigo <<a href="mailto:Rodrigo.Siqueira@amd.com">Rodrigo.Siqueira@amd.com</a>>; <a href="mailto:contact@emersion.fr">contact@emersion.fr</a> <<a href="mailto:contact@emersion.fr">contact@emersion.fr</a>>; Wang, Chao-kai (Stylon) <<a href="mailto:Stylon.Wang@amd.com">Stylon.Wang@amd.com</a>> Subject: RE: [PATCH i-g-t v2] tests/kms_hdr: Fix failure to read output_bpc <o:p></o:p> <div> <o:p></o:p> </div> </div> <div> <div> Can you please post the series link here? Lakshmi. -----Original Message----- From: Rodrigo Siqueira Jordao <<a href="mailto:rjordrigo@amd.com">rjordrigo@amd.com</a>> Sent: Friday, October 8, 2021 12:32 PM To: <a href="mailto:igt-dev@lists.freedesktop.org">igt-dev@lists.freedesktop.org</a>; Vudum, Lakshminarayana <<a href="mailto:lakshminarayana.vudum@intel.com">lakshminarayana.vudum@intel.com</a>> Cc: <a href="mailto:nicholas.choi@amd.com">nicholas.choi@amd.com</a>; <a href="mailto:harry.wentland@amd.com"> harry.wentland@amd.com</a>; <a href="mailto:nicholas.kazlauskas@amd.com">nicholas.kazlauskas@amd.com</a>; <a href="mailto:rodrigo.siqueira@amd.com">rodrigo.siqueira@amd.com</a>; <a href="mailto:contact@emersion.fr"> contact@emersion.fr</a>; Stylon Wang <<a href="mailto:stylon.wang@amd.com">stylon.wang@amd.com</a>> Subject: Re: [PATCH i-g-t v2] tests/kms_hdr: Fix failure to read output_bpc Hi Lakshminarayana, It looks like that we have another false-positive result from the CI in this patch. Thanks Siqueira On 2021-10-08 4:59 a.m., Stylon Wang wrote: > The first commit with TEST_ONLY flag in bpc-switch subtests could fail > the test, because previous state can be with any bpc or even wth no > crtc assigned to the connector. > > v2: > - Keep the test commit for its original purpose of checking > if 512x512 plane size works for the hardware. > - Add new atomic commit so the setting of 8 bpc really takes effect. > > Signed-off-by: Stylon Wang <<a href="mailto:stylon.wang@amd.com">stylon.wang@amd.com</a>> > --- > tests/kms_hdr.c | 22 +++++++++++++--------- > 1 file changed, 13 insertions(+), 9 deletions(-) > > diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c index > 5b8529c8..273263db 100644 > --- a/tests/kms_hdr.c > +++ b/tests/kms_hdr.c > @@ -213,16 +213,27 @@ static void test_bpc_switch_on_output(data_t > *data, igt_output_t *output, > > draw_hdr_pattern(&afb); > > - /* Start in 8bpc. */ > + /* Plane may be required to fit fullscreen. Check it here and allow > + * smaller plane size in following tests. > + */ > igt_plane_set_fb(data->primary, &afb); > igt_plane_set_size(data->primary, data->w, data->h); > - igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, 8); > ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY, NULL); > if (!ret) { > data->w = afb.width; > data->h = afb.height; > } > > + /* Start in 8bpc. */ > + igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, 8); > + igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL); > + /* > + * i915 driver doesn't expose max bpc as debugfs entry, > + * so limiting assert only for amd driver. > + */ > + if (is_amdgpu_device(data->fd)) > + assert_output_bpc(data, 8); > + > /* > * amdgpu requires a primary plane when the CRTC is enabled. > * However, some older Intel hardware (hsw) have scaling @@ > -232,13 +243,6 @@ static void test_bpc_switch_on_output(data_t *data, igt_output_t *output, > if (!is_amdgpu_device(data->fd)) > igt_plane_set_fb(data->primary, NULL); > > - /* > - * i915 driver doesn't expose max bpc as debugfs entry, > - * so limiting assert only for amd driver. > - */ > - if (is_amdgpu_device(data->fd)) > - assert_output_bpc(data, 8); > - > /* Switch to 10bpc. */ > igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, 10); > igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, > NULL); > <o:p></o:p> </div> </div> </div> </div> </body> </html>