<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Hi Lakshminarayana,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Here it is: <a href="https://patchwork.freedesktop.org/series/95601/" id="LPlnk353020">https://patchwork.freedesktop.org/series/95601/</a></div>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Regards</div>
<div id="Signature">
<div>
<div></div>
<div></div>
<div></div>
<div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif">
<p style="margin-top:0px; margin-bottom:0px; margin-top:0; margin-bottom:0"></p>
<p style="margin:0in 0in 0.0001pt; font-size:11pt; font-family:Calibri,sans-serif; color:rgb(32,31,30); text-align:start; background-color:rgb(255,255,255)">
<span style="margin:0px; font-size:9pt; font-family:Arial,sans-serif; color:black"><u><b>Stylon Wang</b></u></span></p>
<p style="margin:0in 0in 0.0001pt; font-size:11pt; font-family:Calibri,sans-serif; color:rgb(32,31,30); text-align:start; background-color:rgb(255,255,255)">
<span style="margin:0px; font-size:9pt; font-family:Arial,sans-serif; color:black">MTS Software Development Eng. |<b> AMD</b><br>
Display Solution Team</span></p>
<p style="margin:0in 0in 0.0001pt; font-size:11pt; font-family:Calibri,sans-serif; color:rgb(32,31,30); text-align:start; background-color:rgb(255,255,255)">
<span style="margin:0px; font-size:9pt; font-family:Arial,sans-serif; color:black"><b style="color:rgb(32,31,30); font-family:Calibri,sans-serif; font-size:14.6667px; background-color:rgb(255,255,255)"><span style="margin:0px; font-size:9pt; font-family:Arial,sans-serif; color:black">O</span></b><span style="margin:0px; font-size:9pt; font-family:Arial,sans-serif; color:black; background-color:rgb(255,255,255)"> +(886)
2-3789-3667 ext. 23667 <b>C</b> +(886) 921-897-142</span><br>
</span></p>
<p style="margin:0in 0in 0.0001pt; font-size:11pt; font-family:Calibri,sans-serif; color:rgb(32,31,30); text-align:start; background-color:rgb(255,255,255)">
<b><span style="margin:0px; font-size:9pt; color:rgb(242,101,34); letter-spacing:-1.4pt">----------------------------------------------------------------------------------------------------------------------------------</span></b><b><span style="margin:0px; font-size:9pt; color:rgb(242,101,34)"></span></b></p>
<p style="margin:0in 0in 0.0001pt; font-size:11pt; font-family:Calibri,sans-serif; color:rgb(32,31,30); text-align:start; background-color:rgb(255,255,255)">
<span style="margin:0px; font-size:9pt; font-family:Arial,sans-serif; color:black"><span tabindex="0" style="margin:0px; padding:1px 0px; border-width:0px 0px 1px; border-bottom-style:dashed">6F, 3, YuanCyu St (NanKang Software Park) Taipei, Taiwan</span></span></p>
<p style="margin:0in 0in 0.0001pt; font-size:11pt; font-family:Calibri,sans-serif; color:rgb(32,31,30); text-align:start; background-color:rgb(255,255,255)">
<span style="margin:0px; font-size:9pt; font-family:Arial,sans-serif; color:black"><a href="https://www.facebook.com/AMD" target="_blank" rel="noopener noreferrer" style="margin:0px"><span style="margin:0px">Facebook</span></a> | <a href="https://twitter.com/AMD" target="_blank" rel="noopener noreferrer" style="margin:0px"><span style="margin:0px">Twitter</span></a> | <a href="http://www.amd.com/" target="_blank" rel="noopener noreferrer" style="margin:0px"><span style="margin:0px">amd.com</span></a></span><span style="margin:0px; font-size:10pt; font-family:Arial,sans-serif; color:black"> </span></p>
<p style="margin:0in 0in 0.0001pt; font-size:11pt; font-family:Calibri,sans-serif; color:rgb(32,31,30); text-align:start; background-color:rgb(255,255,255)">
</p>
<p style="margin-top:0px; margin-bottom:0px; margin-top:0; margin-bottom:0"></p>
</div>
</div>
</div>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com><br>
<b>Sent:</b> October 9, 2021 5:04 AM<br>
<b>To:</b> Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org><br>
<b>Cc:</b> Choi, Nicholas <Nicholas.Choi@amd.com>; Wentland, Harry <Harry.Wentland@amd.com>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; contact@emersion.fr <contact@emersion.fr>; Wang, Chao-kai (Stylon)
<Stylon.Wang@amd.com><br>
<b>Subject:</b> RE: [PATCH i-g-t v2] tests/kms_hdr: Fix failure to read output_bpc</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Can you please post the series link here?<br>
<br>
Lakshmi.<br>
-----Original Message-----<br>
From: Rodrigo Siqueira Jordao <rjordrigo@amd.com> <br>
Sent: Friday, October 8, 2021 12:32 PM<br>
To: igt-dev@lists.freedesktop.org; Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com><br>
Cc: nicholas.choi@amd.com; harry.wentland@amd.com; nicholas.kazlauskas@amd.com; rodrigo.siqueira@amd.com; contact@emersion.fr; Stylon Wang <stylon.wang@amd.com><br>
Subject: Re: [PATCH i-g-t v2] tests/kms_hdr: Fix failure to read output_bpc<br>
<br>
Hi Lakshminarayana,<br>
<br>
It looks like that we have another false-positive result from the CI in this patch.<br>
<br>
Thanks<br>
Siqueira<br>
<br>
On 2021-10-08 4:59 a.m., Stylon Wang wrote:<br>
> The first commit with TEST_ONLY flag in bpc-switch subtests could fail <br>
> the test, because previous state can be with any bpc or even wth no <br>
> crtc assigned to the connector.<br>
> <br>
> v2:<br>
> - Keep the test commit for its original purpose of checking<br>
> if 512x512 plane size works for the hardware.<br>
> - Add new atomic commit so the setting of 8 bpc really takes effect.<br>
> <br>
> Signed-off-by: Stylon Wang <stylon.wang@amd.com><br>
> ---<br>
> tests/kms_hdr.c | 22 +++++++++++++---------<br>
> 1 file changed, 13 insertions(+), 9 deletions(-)<br>
> <br>
> diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c index <br>
> 5b8529c8..273263db 100644<br>
> --- a/tests/kms_hdr.c<br>
> +++ b/tests/kms_hdr.c<br>
> @@ -213,16 +213,27 @@ static void test_bpc_switch_on_output(data_t <br>
> *data, igt_output_t *output,<br>
> <br>
> draw_hdr_pattern(&afb);<br>
> <br>
> - /* Start in 8bpc. */<br>
> + /* Plane may be required to fit fullscreen. Check it here and allow<br>
> + * smaller plane size in following tests.<br>
> + */<br>
> igt_plane_set_fb(data->primary, &afb);<br>
> igt_plane_set_size(data->primary, data->w, data->h);<br>
> - igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, 8);<br>
> ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY, NULL);<br>
> if (!ret) {<br>
> data->w = afb.width;<br>
> data->h = afb.height;<br>
> }<br>
> <br>
> + /* Start in 8bpc. */<br>
> + igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, 8);<br>
> + igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);<br>
> + /*<br>
> + * i915 driver doesn't expose max bpc as debugfs entry,<br>
> + * so limiting assert only for amd driver.<br>
> + */<br>
> + if (is_amdgpu_device(data->fd))<br>
> + assert_output_bpc(data, 8);<br>
> +<br>
> /*<br>
> * amdgpu requires a primary plane when the CRTC is enabled.<br>
> * However, some older Intel hardware (hsw) have scaling @@ <br>
> -232,13 +243,6 @@ static void test_bpc_switch_on_output(data_t *data, igt_output_t *output,<br>
> if (!is_amdgpu_device(data->fd))<br>
> igt_plane_set_fb(data->primary, NULL);<br>
> <br>
> - /*<br>
> - * i915 driver doesn't expose max bpc as debugfs entry,<br>
> - * so limiting assert only for amd driver.<br>
> - */<br>
> - if (is_amdgpu_device(data->fd))<br>
> - assert_output_bpc(data, 8);<br>
> -<br>
> /* Switch to 10bpc. */<br>
> igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, 10);<br>
> igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET,
<br>
> NULL);<br>
> <br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>