<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<div>On Wed, 2022-03-16 at 09:24 -0400, Rodrigo Siqueira Jordao wrote:</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div><br>
</div>
<div><br>
</div>
<div>On 2022-03-01 14:55, Rodrigo Vivi wrote:<br>
</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div>On Thu, Feb 17, 2022 at 10:26:44AM -0500, Rodrigo Siqueira wrote:<br>
</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div>IGT is becoming more generic, and multiple vendors are adopting it. For<br>
</div>
<div>example, AMD fully upstream all of its internal changes last year, and<br>
</div>
<div>now we are relying on IGT from the upstream. Additionally, thanks to the<br>
</div>
<div>ChromeOS project, we have other vendors working on the KMS tests as<br>
</div>
<div>well. At this point, I believe that we need some mechanism to better<br>
</div>
<div>contact developers that care about some specific tests or even provide<br>
</div>
<div>an easy way for other people to find the right stakeholder for dealing<br>
</div>
<div>with some particular issue.<br>
</div>
<div><br>
</div>
<div>Imho Linux Kernel already has a good solution codified in the<br>
</div>
<div>MAINTAINERS and get_maintainers files. One of the best things about this<br>
</div>
<div>approach was adding reviewers and maintainers (and other options) to the<br>
</div>
<div>specific part of the code and using the get_maintainers tool to extract<br>
</div>
<div>the right people to be part of the series. With this idea in mind, I<br>
</div>
<div>created an RFC that introduces the MAINTAINERS file in IGT, and<br>
</div>
<div>collected feedback. This series is the first version that introduces the<br>
</div>
<div>MAINTAINERS and a wrapper to the get_maintainers file.<br>
</div>
</blockquote>
<div><br>
</div>
<div>But in the Linux Kernel we do for big blocks, not for individual .c files.<br>
</div>
<div>For the .c files git blame should be enough imho...<br>
</div>
</blockquote>
<div><br>
</div>
<div>Hi Rodrigo,<br>
</div>
<div><br>
</div>
<div>I don't think git blame will work for what I'm suggesting. What I'm <br>
</div>
<div>trying to achieve here is a bit different; I'm trying to add more <br>
</div>
<div>contact points for specific tests since IGT became more and more adopted.<br>
</div>
<div>For example, last year, we retired our IGT fork and tried to upstream <br>
</div>
<div>all of our internal changes since we want to move to the upstream first <br>
</div>
<div>approach with IGT. As a result of this change, our CI now relies on IGT <br>
</div>
<div>from GitLab, and we run a lot of the kms tests, but we did not directly <br>
</div>
<div>work in some of them. In those cases, git blame will not point to anyone <br>
</div>
<div>from AMD. If you see the first patch, we are trying to add specific <br>
</div>
<div>people to follow certain tests to make the IGT maintenance scalable for <br>
</div>
<div>us and for anyone using IGT in their CI.<br>
</div>
</blockquote>
<div><br>
</div>
<div>I totally understand your goal here and I fully support any action that brings the</div>
<div>upstream first approach. My biggest concern with this approach is the maintenance cost.</div>
<div>A list big and very specific like this will likely change quickly and get outdated in the blink of an eye.</div>
<div><br>
</div>
<div>But it is just my personal thought on this. Please sync with Petri to determine the good path of this.</div>
<div><br>
</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div><br>
</div>
<div>Thanks<br>
</div>
<div>Siqueira<br>
</div>
<div><br>
</div>
<div><br>
</div>
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">
<div><br>
</div>
<div>For this series, I recommend:<br>
</div>
<div><br>
</div>
<div>1. Patch 1: It has the maintainers file. If you want to add yourself to<br>
</div>
<div>some specific test, please, let me know in this patch.<br>
</div>
<div>2. Patch 2: get_maintainers wrapper, see the CONTRIBUTING page on how to<br>
</div>
<div>use it.<br>
</div>
<div><br>
</div>
<div>Cc: Arkadiusz Hiler <<a href="mailto:arek@hiler.eu">arek@hiler.eu</a>><br>
</div>
<div>Cc: Petri Latvala <<a href="mailto:petri.latvala@intel.com">petri.latvala@intel.com</a>><br>
</div>
<div>Cc: Mark Yacoub <<a href="mailto:markyacoub@google.com">markyacoub@google.com</a>><br>
</div>
<div>Cc: Jessica Zhang <<a href="mailto:quic_jesszhan@quicinc.com">quic_jesszhan@quicinc.com</a>><br>
</div>
<div>Cc: Abhinav Kumar <<a href="mailto:quic_abhinavk@quicinc.com">quic_abhinavk@quicinc.com</a>><br>
</div>
<div>Cc: Melissa Wen <<a href="mailto:mwen@igalia.com">mwen@igalia.com</a>><br>
</div>
<div>Cc: Sean Paul <<a href="mailto:seanpaul@chromium.org">seanpaul@chromium.org</a>><br>
</div>
<div>Cc: Harry Wentland <<a href="mailto:harry.wentland@amd.com">harry.wentland@amd.com</a>><br>
</div>
<div>Cc: Sun Peng Li(Leo) <<a href="mailto:sunpeng.li@amd.com">sunpeng.li@amd.com</a>><br>
</div>
<div>Cc: Chao-kai Wang (Stylon) <<a href="mailto:stylon.wang@amd.com">stylon.wang@amd.com</a>><br>
</div>
<div>Cc: Wayne Lin <<a href="mailto:wayne.lin@amd.com">wayne.lin@amd.com</a>><br>
</div>
<div>Cc: Nicholas Choi <<a href="mailto:nicholas.choi@amd.com">nicholas.choi@amd.com</a>><br>
</div>
<div>Cc: Martin Peres <<a href="mailto:martin.peres@mupuf.org">martin.peres@mupuf.org</a>><br>
</div>
<div>Cc: Aurabindo Pillai <<a href="mailto:aurabindo.pillai@amd.com">aurabindo.pillai@amd.com</a>><br>
</div>
<div>Cc: Bhawanpreet Lakha <<a href="mailto:bhawanpreet.lakha@amd.com">bhawanpreet.lakha@amd.com</a>><br>
</div>
<div>Cc: Qingqing Zhuo (Lilian) <<a href="mailto:qingqing.zhuo@amd.com">qingqing.zhuo@amd.com</a>><br>
</div>
<div>Cc: Solomon Chiu <<a href="mailto:solomon.chiu@amd.com">solomon.chiu@amd.com</a>><br>
</div>
<div>Cc: Nicholas Kazlauskas <<a href="mailto:nicholas.kazlauskas@amd.com">nicholas.kazlauskas@amd.com</a>><br>
</div>
<div>Cc: Dingchen Zhang (David) <<a href="mailto:Dingchen.Zhang@amd.com">Dingchen.Zhang@amd.com</a>><br>
</div>
<div><br>
</div>
<div>Rodrigo Siqueira (2):<br>
</div>
<div> MAINTAINERS: Introduce MAINTAINERS file<br>
</div>
<div> scripts: get_maintainer: Introduce get_maintainer wrapper<br>
</div>
<div><br>
</div>
<div> .gitignore | 1 +<br>
</div>
<div> CONTRIBUTING.md | 17 +++-<br>
</div>
<div> MAINTAINERS | 198 +++++++++++++++++++++++++++++++++++++-<br>
</div>
<div> scripts/get_maintainer.sh | 104 ++++++++++++++++++++<br>
</div>
<div> 4 files changed, 317 insertions(+), 3 deletions(-)<br>
</div>
<div> create mode 100755 scripts/get_maintainer.sh<br>
</div>
<div><br>
</div>
<div>-- <br>
</div>
<div>2.25.1<br>
</div>
<div><br>
</div>
</blockquote>
</blockquote>
<div><br>
</div>
</blockquote>
<div><br>
</div>
<div><span></span></div>
</body>
</html>