<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com><br>
</div>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="Signature">
<div>
<div></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
--</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Regards,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Jay<br>
</div>
</div>
</div>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Zhang, Dingchen (David) <Dingchen.Zhang@amd.com><br>
<b>Sent:</b> Wednesday, April 6, 2022 4:28 PM<br>
<b>To:</b> igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org><br>
<b>Cc:</b> Siqueira, Rodrigo <Rodrigo.Siqueira@amd.com>; Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Pillai, Aurabindo <Aurabindo.Pillai@amd.com>; Lin, Wayne <Wayne.Lin@amd.com><br>
<b>Subject:</b> [PATCH 1/2] tests/amdgpu/amd_psr: use PSR state enum replace the integer</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">[why & how]<br>
The enum of AMDGPU PSR STATE may update along the time and should<br>
be aligned to the code base of upstream. Instead of using hard-<br>
coded integer, replace them with enum PSR_STATE would be preferred<br>
and we only need to update the PSR_STATE enum if needed in the<br>
future.<br>
<br>
Cc: Rodrigo Siqueira <rodrigo.siqueira@amd.com><br>
Cc: Harry Wentland <harry.wentland@amd.com><br>
Cc: Leo Li <sunpeng.li@amd.com><br>
Cc: Jay Pillai <aurabindo.pillai@amd.com><br>
Cc: Wayne Lin <wayne.lin@amd.com><br>
<br>
Signed-off-by: David Zhang <dingchen.zhang@amd.com><br>
---<br>
tests/amdgpu/amd_psr.c | 8 ++++----<br>
1 file changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/tests/amdgpu/amd_psr.c b/tests/amdgpu/amd_psr.c<br>
index d21d41e3..83e44c4e 100644<br>
--- a/tests/amdgpu/amd_psr.c<br>
+++ b/tests/amdgpu/amd_psr.c<br>
@@ -179,10 +179,10 @@ static void run_check_psr(data_t *data, bool test_null_crtc) {<br>
continue;<br>
<br>
psr_state = igt_amd_read_psr_state(data->fd, output->name);<br>
- igt_fail_on_f(psr_state < 0, "Open PSR state debugfs failed\n");<br>
- igt_fail_on_f(psr_state < 1, "PSR was not enabled for connector %s\n", output->name);<br>
- igt_fail_on_f(psr_state == 0xff, "PSR is invalid for connector %s\n", output->name);<br>
- igt_fail_on_f(psr_state != 5, "PSR state is expected to be at 5 on a "<br>
+ igt_fail_on_f(psr_state < PSR_STATE0, "Open PSR state debugfs failed\n");<br>
+ igt_fail_on_f(psr_state < PSR_STATE1, "PSR was not enabled for connector %s\n", output->name);<br>
+ igt_fail_on_f(psr_state == PSR_STATE_INVALID, "PSR is invalid for connector %s\n", output->name);<br>
+ igt_fail_on_f(psr_state != PSR_STATE3, "PSR state is expected to be at PSR_STATE3 (Active) on a "<br>
"static screen for connector %s\n", output->name);<br>
}<br>
<br>
-- <br>
2.25.1<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>