<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only - General]<br>
</p>
<br>
<div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks Mark. </div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I will update in V3 after collecting more feedbacks.</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Mark Yacoub <markyacoub@chromium.org><br>
<b>Sent:</b> 09 May 2022 10:34<br>
<b>To:</b> Hung, Alex <Alex.Hung@amd.com><br>
<b>Cc:</b> igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org>; markyacoub@google.com <markyacoub@google.com><br>
<b>Subject:</b> Re: [igt-dev] [PATCH 2/2 i-g-t][V2] tests/kms_universal_plane: Enable gen9_test_pipe for all devices</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On Mon, May 9, 2022 at 11:51 AM Alex Hung <alex.hung@amd.com> wrote:<br>
><br>
> This subtest runs on non-i915 devices, and let's make it generic by<br>
I like this, thank you!<br>
> removing igt_require_intel and renaming it.<br>
><br>
> Signed-off-by: Alex Hung <alex.hung@amd.com><br>
> ---<br>
> tests/kms_universal_plane.c | 11 +++++------<br>
> 1 file changed, 5 insertions(+), 6 deletions(-)<br>
><br>
> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c<br>
> index 3a3667e6..eab99962 100644<br>
> --- a/tests/kms_universal_plane.c<br>
> +++ b/tests/kms_universal_plane.c<br>
> @@ -701,15 +701,14 @@ gen9_test_fini(gen9_test_t *test, igt_output_t *output)<br>
> * windowing)<br>
> */<br>
> static void<br>
> -gen9_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)<br>
> +pageflip_win_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)<br>
> {<br>
> gen9_test_t test = { .data = data };<br>
> igt_plane_t *primary;<br>
><br>
> int ret = 0;<br>
> -<br>
> - igt_require_intel(data->drm_fd);<br>
> - igt_skip_on(data->display_ver < 9);<br>
> + if (is_i915_device(data->drm_fd))<br>
> + igt_skip_on(data->display_ver < 9);<br>
you can do instead ` igt_skip_on(is_i915_device(data->drm_fd) &&<br>
data->display_ver < 9);`<br>
> igt_require_pipe(&data->display, pipe);<br>
><br>
> igt_output_set_pipe(output, pipe);<br>
> @@ -789,10 +788,10 @@ run_tests_for_pipe(data_t *data, enum pipe pipe)<br>
> cursor_leak_test_pipe(data, pipe, output);<br>
><br>
> igt_describe("Check if pageflip succeeds in windowed setting");<br>
> - igt_subtest_f("universal-plane-gen9-features-pipe-%s",<br>
> + igt_subtest_f("universal-plane-pageflip-windowed-pipe-%s",<br>
> kmstest_pipe_name(pipe))<br>
> for_each_valid_output_on_pipe(&data->display, pipe, output)<br>
> - gen9_test_pipe(data, pipe, output);<br>
> + pageflip_win_test_pipe(data, pipe, output);<br>
> }<br>
><br>
> static data_t data;<br>
> --<br>
> 2.25.1<br>
><br>
</div>
</span></font></div>
</div>
</body>
</html>