<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> [AMD Official Use Only - General] <div> <div class="elementToProof" style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Helvetica Neue", sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"> Thanks for the feedback. I will drop patch 2</div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr">From: Petri Latvala <petri.latvala@intel.com> Sent: 14 December 2022 01:30 To: Hung, Alex <Alex.Hung@amd.com> Cc: igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org> Subject: Re: [igt-dev] [PATCH 2/2] tests/kms_bw: Run tests on available pipes only <div> </div> </div> <div class="BodyFragment"> <div class="PlainText">On Tue, Dec 13, 2022 at 04:43:32PM -0700, Alex Hung wrote: > This cleans up unnecessary skips during executions. > > Signed-off-by: Alex Hung <alex.hung@amd.com> > --- > tests/kms_bw.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/tests/kms_bw.c b/tests/kms_bw.c > index 27100587..ac801746 100644 > --- a/tests/kms_bw.c > +++ b/tests/kms_bw.c > @@ -145,17 +145,9 @@ static void run_test_linear_tiling(data_t *data, int pipe, const drmModeModeInfo > igt_output_t *output; > struct igt_fb buffer[IGT_MAX_PIPES]; > igt_crc_t zero, captured[IGT_MAX_PIPES]; > - int i = 0, num_pipes = 0; > - enum pipe p; > + int i = 0; > int ret; > > - /* Cannot use igt_display_get_n_pipes() due to fused pipes on i915 where they do > - * not give the numver of valid crtcs and always return IGT_MAX_PIPES */ > - for_each_pipe(display, p) num_pipes++; > - > - igt_skip_on_f(pipe > num_pipes, > - "ASIC does not have %d pipes\n", pipe); > - > test_init(data); > > /* create buffers */ > @@ -204,6 +196,7 @@ igt_main > { > data_t data; > int i = 0, j = 0; > + enum pipe p; > > memset(&data, 0, sizeof(data)); > > @@ -219,14 +212,13 @@ igt_main > > } > > - /* We're not using for_each_pipe_static because we need the > - * _amount_ of pipes */ > - for (i = 0; i < IGT_MAX_PIPES; i++) { > + for_each_pipe(&data.display, p) { > for (j = 0; j < ARRAY_SIZE(test_mode); j++) { > igt_subtest_f("linear-tiling-%d-displays-%s", i+1, > test_mode[j].name) > run_test_linear_tiling(&data, i, &test_mode[j]); > } > + i++; > } When enumerating tests with --list-subtests you don't have data.display valid. As gitlab pipeline relay warned for this series. What you can do is make this an igt_subtest_with_dynamic, and igt_subtest_with_dynamic_f("linear-tiling-multiple-displays-%s", test_mode[j].name) { for_each_pipe(&data.display, p) { igt_dynamic_f("%d-displays", i+1) { run_test_linear_tiling(&data, i, &test_mode[j]); } } } However, even with that in place, using for_each_pipe sounds wrong. As the comment says, this is using an _amount_ of pipes, not one particular pipe. -- Petri Latvala </div> </div> </div> </body> </html>