<div dir="ltr"><div dir="ltr"><div><div dir="ltr" class="gmail_signature"><div dir="ltr"><br></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jul 25, 2023 at 3:40 PM Javier Martinez Canillas <<a href="mailto:javierm@redhat.com">javierm@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Hello Albert,<br>
<br>
Patch looks good to me. But I'm not really familiar with the IGT codebase.<br>
<br>
Acked-by: Javier Martinez Canillas <<a href="mailto:javierm@redhat.com" target="_blank">javierm@redhat.com</a>><br>
<br>
I've one question below though:<br>
<br>
Albert Esteve <<a href="mailto:aesteve@redhat.com" target="_blank">aesteve@redhat.com</a>> writes:<br>
<br>
[...]<br>
<br>
> @@ -2679,6 +2686,8 @@ void igt_display_require(igt_display_t *display, int drm_fd)<br>
> drmSetClientCap(drm_fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);<br>
> if (drmSetClientCap(drm_fd, DRM_CLIENT_CAP_ATOMIC, 1) == 0)<br>
> display->is_atomic = 1;<br>
> + <br>
> + drmSetClientCap(drm_fd, DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT, 1);<br>
><br>
<br>
Should this capability be set unconditionally? <br>
<br></blockquote><div><br></div><div>Probably could be set similarly to how the atomic capability is set, track the property in the display</div><div>structure, and run the hotspot test only in cases where client understands hotspot properties.</div><div>I can change this in the next drop.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Do we want to also test the case when user-space doesn't opt-in and does<br>
not know how to handle the hostpost properties ?<br></blockquote><div><br></div><div>In those cases, if setting the capability fails, it is probably better to just skip the test.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
-- <br>
Best regards,<br>
<br>
Javier Martinez Canillas<br>
Core Platforms<br>
Red Hat<br>
<br>
</blockquote></div></div>