<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <meta name="Generator" content="Microsoft Exchange Server">  <style></style> </head> <body> <font face="Calibri" size="2"><span style="font-size:11pt;"> <div>Hi, <a name="_MailEndCompose"></a></div> <div>> -----Original Message-----</div> <div>> From: Saarinen, Jani</div> <div>> Sent: Wednesday, November 15, 2023 10:47 AM</div> <div>> To: Ville Syrjälä <ville.syrjala@linux.intel.com>; Modem, Bhanuprakash</div> <div>> <Bhanuprakash.Modem@intel.com></div> <div>> Cc: igt-dev@lists.freedesktop.org</div> <div>> Subject: RE: [igt-dev] [i-g-t 4/5] tests/kms_flip: Fix Bigjoiner checks</div> <div>> </div> <div>> Hi,</div> <div>> > -----Original Message-----</div> <div>> > From: igt-dev <<a href="mailto:igt-dev-bounces@lists.freedesktop.org">igt-dev-bounces@lists.freedesktop.org</a>> On Behalf Of</div> <div>> > Ville Syrjälä</div> <div>> > Sent: Wednesday, November 15, 2023 10:35 AM</div> <div>> > To: Modem, Bhanuprakash <<a href="mailto:bhanuprakash.modem@intel.com">bhanuprakash.modem@intel.com</a>></div> <div>> > Cc: <a href="mailto:igt-dev@lists.freedesktop.org">igt-dev@lists.freedesktop.org</a></div> <div>> > Subject: Re: [igt-dev] [i-g-t 4/5] tests/kms_flip: Fix Bigjoiner</div> <div>> > checks</div> <div>> ></div> <div>> > On Mon, Nov 13, 2023 at 01:49:29PM +0530, Bhanuprakash Modem wrote:</div> <div>> > > Bigjoiner will come in the picture when the resolution > 5K or clock</div> <div>> > > > max dot-clock. Add a support to check the selected mode clock is</div> <div>> > > greater than the max dot-clock.</div> <div>> > ></div> <div>> > > V2: - Limit the bigjoiner checks to intel hardware</div> <div>> > ></div> <div>> > > Signed-off-by: Bhanuprakash Modem <<a href="mailto:bhanuprakash.modem@intel.com">bhanuprakash.modem@intel.com</a>></div> <div>> > > Reviewed-by: Ankit Nautiyal <<a href="mailto:ankit.k.nautiyal@intel.com">ankit.k.nautiyal@intel.com</a>></div> <div>> > > ---</div> <div>> > > tests/kms_flip.c | 18 +++++++++++-------</div> <div>> > > 1 file changed, 11 insertions(+), 7 deletions(-)</div> <div>> > ></div> <div>> > > diff --git a/tests/kms_flip.c b/tests/kms_flip.c index</div> <div>> > > fc7cee050..d34596599 100755</div> <div>> > > --- a/tests/kms_flip.c</div> <div>> > > +++ b/tests/kms_flip.c</div> <div>> > <snip></div> <div>> > > @@ -2136,6 +2139,7 @@ igt_main_args("e", NULL, help_str,</div> <div>> > > opt_handler,</div> <div>> > NULL)</div> <div>> > > for (i = 0; i < sizeof(tests) / sizeof(tests[0]); i++)</div> <div>> > > tests[i].flags &= ~(TEST_CHECK_TS |</div> <div>> > TEST_VBLANK_EXPIRED_SEQ);</div> <div>> > > }</div> <div>> > > + max_dotclock = igt_get_max_dotclock(drm_fd);</div> <div>> ></div> <div>> > That seems to have broken the test for !display platforms (bat-atsm-1).</div> <div>> We were just trying to figure out what has happened on <a href="https://intel-gfx-ci.01.org/tree/drm-tip/bat-atsm-1.html">https://intel-gfx-</a></div> <div>> ci.01.org/tree/drm-tip/bat-atsm-1.html as was also visible on Linux next</div> <div>> <a href="https://intel-gfx-ci.01.org/tree/linux-next/bat-atsm-1.html">https://intel-gfx-ci.01.org/tree/linux-next/bat-atsm-1.html</a> .</div> <div>> </div> <div>> But thanks Ville commenting that this is about IGT.</div> <div>Indeed IGT changed between skip and fail (bolded) </div> <div><b>328c5873b</b> tests/intel/xe_exec_queue_property: Negative tests for get exec_queue property ioctl ===(IGT_7588)===</div> <div> </div> <div>bec435c24 tests/intel/kms_dsc: remove redundant documentation ===(IGT_7587)===</div> <div>37c3d2d4c tests/intel/kms_dsc: add test to validate fractional bpp with input bpc</div> <div>a83d0d03c tests/intel/kms_dsc: enable validation for vdsc fractional bpp</div> <div>40bb84ee2 lib/dsc: add helpers for vdsc fractional bpp debugfs entry</div> <div>d99e8f119 lib/dsc: fix documentation style</div> <div> </div> <div>c422858f8 tests/xe_evict_ccs: Disable compression on platforms without flatccs ===(IGT_7586)===</div> <div> </div> <div>f7ae24e64 syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED | WAIT_AVAILABLE ===(IGT_7585)===</div> <div>8c244b802 tests/kms_setmode: Fix Bigjoiner checks</div> <div>3d5cd7d99 tests/kms_flip: Fix Bigjoiner checks</div> <div>a6ca34472 tests/i915/kms_big_joiner: Fix Bigjoiner checks</div> <div>9d45e7aae lib/igt_kms: s/is_i915_device/is_intel_device</div> <div>53d1677a8 tests: s/i915_pipe_output_combo_valid/intel_pipe_output_combo_valid/</div> <div> </div> <div>30e6ded90 Revert "syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE" ===(IGT_7584)===</div> <div>f6f590334 syncobj_timeline: don't expect EINVAL for WAIT_UNSUBMITTED, | WAIT_AVAILABLE</div> <div> </div> <div>NO git-log.txt ===(IGT_7583)===</div> <div> </div> <div>453b9df12 tests/intel/xe_exec_queue_property: Add scheduler exec queue set property ===(IGT_7582)===</div> <div>60f199d7b tests/intel/xe_exec_queue_property: Add exec queue set property tests</div> <div><b>897748a32</b> tests/intel/xe_waitfence: Add invalid-engine subtest ===(IGT_7581)===</div> <div>> </div> <div>> </div> <div>> ></div> <div>> > > }</div> <div>> > ></div> <div>> > > igt_describe("Tests that nonblocking reading fails correctly");</div> <div>> > > --</div> <div>> > > 2.40.0</div> <div>> ></div> <div>> > --</div> <div>> > Ville Syrjälä</div> <div>> > Intel</div> <div> </div> </span></font> </body> </html>