<!DOCTYPE html><html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> <div class="moz-cite-prefix">On 12/8/2023 11:24, Marcin Bernatowicz wrote: </div> <blockquote type="cite" cite="mid:20231208102438.12894-1-marcin.bernatowicz@linux.intel.com"> <pre class="moz-quote-pre" wrap="">During the split of xe_sync types from flags introduced in commit ce4e53b0faec ("drm-uapi/xe: Split xe_sync types from flags"), the array index of xe_sync objects was unnecessarily incremented in one of the lines. This caused the next line to reference the wrong xe_sync object. This patch fixes the array index issue, ensuring the correct xe_sync object is referenced. Fixes: ce4e53b0faec ("drm-uapi/xe: Split xe_sync types from flags") Signed-off-by: Marcin Bernatowicz <a class="moz-txt-link-rfc2396E" href="mailto:marcin.bernatowicz@linux.intel.com"><marcin.bernatowicz@linux.intel.com></a> --- benchmarks/gem_wsim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c index e937e1027..30673da8f 100644 --- a/benchmarks/gem_wsim.c +++ b/benchmarks/gem_wsim.c @@ -1784,7 +1784,7 @@ xe_alloc_step_batch(struct workload *wrk, struct w_step *w) i = 0; /* out fence */ w->xe.syncs[i].handle = syncobj_create(fd, 0); - w->xe.syncs[i++].type = DRM_XE_SYNC_TYPE_SYNCOBJ; + w->xe.syncs[i].type = DRM_XE_SYNC_TYPE_SYNCOBJ; w->xe.syncs[i++].flags = DRM_XE_SYNC_FLAG_SIGNAL; /* in fence(s) */ for_each_dep(dep, w->data_deps) {</pre> </blockquote> Reviewed-by: Lukasz Laguna <<a href="mailto:lukasz.laguna@intel.com">lukasz.laguna@intel.com</a>> </body> </html>