<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 2/1/2024 11:31 PM, Zbigniew
Kempczyński wrote:<br>
</div>
<blockquote type="cite" cite="mid:20240202073101.qdi3phnk23ma3j2r@zkempczy-mobl2">
<pre class="moz-quote-pre" wrap="">On Thu, Feb 01, 2024 at 09:34:27PM -0800, Jahagirdar, Akshata wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
+
if (config->compression && !blt_block_copy_supports_compression(xe))
return;
This will check compression either, but indirectly via .cmds_info
set to xe2_cmds_info in which we use BLT_CMD_SUPPORTS_COMPRESSION
flag for block-copy command.
on a side note, IIUC the BLT_CMD_SUPPORTS_COMPRESSION flag doesn't make
sense anymore due to xe2+ unified compression?
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Please fix your email client, it's hard to extract the answer.
Regarding above - may you elaborate?
--
Zbigniew
</pre>
</blockquote>
Hi, sorry about that. not sure why it didn't quote properly before.
Hope it is fixed now.<br>
<p>So, regarding my previous comment, The
BLT_CMD_SUPPORTS_COMPRESSION flag checks if the "block-copy
command" supports compression or not.</p>
<p>However, due to the unified compression in xe2+, we <span><span class="ui-provider ed bcp bcq bcr bcs bct bcu bcv bcw bcx bcy bcz bda bdb bdc bdd bde bdf bdg bdh bdi bdj bdk bdl bdm bdn bdo bdp bdq bdr bds bdt bdu bdv bdw" dir="ltr">don't need to use specific blitter commands to use
compression any more.</span></span></p>
<p><span><span class="ui-provider ed bcp bcq bcr bcs bct bcu bcv bcw bcx bcy bcz bda bdb bdc bdd bde bdf bdg bdh bdi bdj bdk bdl bdm bdn bdo bdp bdq bdr bds bdt bdu bdv bdw" dir="ltr">So, i wanted to say that this flag checking
compression support doesn't make sense anymore for xe2, but I
understand it would be different based on platform specific
.cmds_info. <br>
</span></span></p>
<p><span><span class="ui-provider ed bcp bcq bcr bcs bct bcu bcv bcw bcx bcy bcz bda bdb bdc bdd bde bdf bdg bdh bdi bdj bdk bdl bdm bdn bdo bdp bdq bdr bds bdt bdu bdv bdw" dir="ltr">I didn't check it properly before.<br>
</span></span></p>
<p><span><span class="ui-provider ed bcp bcq bcr bcs bct bcu bcv bcw bcx bcy bcz bda bdb bdc bdd bde bdf bdg bdh bdi bdj bdk bdl bdm bdn bdo bdp bdq bdr bds bdt bdu bdv bdw" dir="ltr">So anyway: Reviewed-by: Akshata Jahagirdar
<a class="moz-txt-link-rfc2396E" href="mailto:akshata.jahagirdar@intel.com"><akshata.jahagirdar@intel.com></a><br>
</span></span></p>
<span><span class="ui-provider ed bcp bcq bcr bcs bct bcu bcv bcw bcx bcy bcz bda bdb bdc bdd bde bdf bdg bdh bdi bdj bdk bdl bdm bdn bdo bdp bdq bdr bds bdt bdu bdv bdw" dir="ltr">-Akshata</span></span>
<blockquote type="cite" cite="mid:20240202073101.qdi3phnk23ma3j2r@zkempczy-mobl2">
<pre class="moz-quote-pre" wrap="">
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">
- Akshata
Do we have any Xe2 without compression on block-copy?
--
Zbigniew
--
2.43.0
</pre>
</blockquote>
</blockquote>
</body>
</html>