<!DOCTYPE html><html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> <div class="moz-cite-prefix">On 3/22/2024 1:53 PM, Matt Roper wrote: </div> <blockquote type="cite" cite="mid:20240322205327.850864-1-matthew.d.roper@intel.com"> <pre class="moz-quote-pre" wrap="">igt@xe_vm@bind-flag-invalid should no longer consider BIT(3) an invalid flag and expect failure since that is now used by DRM_XE_VM_BIND_FLAG_DUMPABLE. Closes: <a class="moz-txt-link-freetext" href="https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1285">https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1285</a> Signed-off-by: Matt Roper <a class="moz-txt-link-rfc2396E" href="mailto:matthew.d.roper@intel.com"><matthew.d.roper@intel.com></a> --- tests/intel/xe_vm.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c index 7c061c497..00c428bb5 100644 --- a/tests/intel/xe_vm.c +++ b/tests/intel/xe_vm.c @@ -1805,6 +1805,11 @@ static void bind_flag_invalid(int fd) syncobj_reset(fd, &sync[0].handle, 1); bind.bind.obj = bo; + bind.bind.flags = DRM_XE_VM_BIND_FLAG_DUMPABLE; + igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind); + igt_assert(syncobj_wait(fd, &sync[0].handle, 1, INT64_MAX, 0, NULL)); + syncobj_reset(fd, &sync[0].handle, 1); + /* Using invalid flags should not work */ bind.bind.flags = 1 << 0; igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind); @@ -1814,10 +1819,6 @@ static void bind_flag_invalid(int fd) igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind); do_ioctl_err(fd, DRM_IOCTL_XE_VM_BIND, &bind, EINVAL); - bind.bind.flags = 1 << 3; - igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind); - do_ioctl_err(fd, DRM_IOCTL_XE_VM_BIND, &bind, EINVAL); - /* Using valid flags should still work */ bind.bind.flags = 0; igt_ioctl(fd, DRM_IOCTL_XE_VM_BIND, &bind);</pre> </blockquote> This patch provides a partial fix for VLK-54352, and together with my patch it solves the issue. Reviewed-by: Jagmeet Randhawa <<span style="color: rgb(50, 49, 48); font-family: "Segoe UI Variable Text", "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: normal; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;"><a class="moz-txt-link-abbreviated" href="mailto:jagmeet.randhawa@intel.com">jagmeet.randhawa@intel.com</a>> <blockquote type="cite" cite="mid:20240322205327.850864-1-matthew.d.roper@intel.com"> <pre class="moz-quote-pre" wrap=""> </pre> </blockquote> </body> </html>