<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body>
    <p>Hi JP,<br>
    </p>
    <div class="moz-cite-prefix">On 9/12/2024 8:16 PM, Juha-Pekka
      Heikkila wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:20240912144645.862462-1-juhapekka.heikkila@gmail.com">
      <pre wrap="" class="moz-quote-pre">On Intel Xe2 hw Tile4 no longer can be used with horizontal flip on display.
bspec 69853

Signed-off-by: Juha-Pekka Heikkila <a class="moz-txt-link-rfc2396E" href="mailto:juhapekka.heikkila@gmail.com"><juhapekka.heikkila@gmail.com></a>
---
 tests/kms_rotation_crc.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 8d8c53b5f..3e9190590 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -639,6 +639,12 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
                            !IS_CHERRYVIEW(data->devid) ||
                            data->rotation != (IGT_ROTATION_180 | IGT_REFLECT_X));
 
+               /* Intel Xe2 onwards cannot do reflect tile4 */
+               igt_require(!is_intel_device(data->gfx_fd) ||
+                           intel_gen(data->devid) < 20 ||
+                           !(data->override_modifier == I915_FORMAT_MOD_4_TILED &&
+                           data->rotation&IGT_REFLECT_X));
+</pre>
    </blockquote>
    <span style="color: rgb(17, 17, 17); font-family: -apple-system, Roboto, SegoeUI, "Segoe UI", "Helvetica Neue", Helvetica, "Microsoft YaHei", "Meiryo UI", Meiryo, "Arial Unicode MS", sans-serif; font-size: 16px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: left; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: normal; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;">As
      per BSpec (69853) up to XE2, horizontal flip is not supported with
      linear surface formats. If it is valid to add that check, please
      do so.</span><span style="color: rgb(35, 35, 35); font-family: Arial, sans-serif; font-size: 13.3333px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: normal; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;"> 
    </span>
    <blockquote type="cite" cite="mid:20240912144645.862462-1-juhapekka.heikkila@gmail.com">
      <pre wrap="" class="moz-quote-pre">
                prepare_crtc(data, output, pipe, plane, true);
 
                for (i = 0; i < num_rectangle_types; i++) {
</pre>
    </blockquote>
  </body>
</html>