<!DOCTYPE html><html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> <p><br> </p> <div class="moz-cite-prefix">On 11/11/2024 11:49 AM, Samala, Pranay wrote:<br> </div> <blockquote type="cite" cite="mid:PH7PR11MB6053D85677A7EDB6C2071357E7582@PH7PR11MB6053.namprd11.prod.outlook.com"> <pre wrap="" class="moz-quote-pre"> -----Original Message----- From: Samala, Pranay <a class="moz-txt-link-rfc2396E" href="mailto:pranay.samala@intel.com"><pranay.samala@intel.com></a> Sent: Wednesday, November 6, 2024 2:49 PM To: <a class="moz-txt-link-abbreviated" href="mailto:igt-dev@lists.freedesktop.org">igt-dev@lists.freedesktop.org</a> Cc: B S, Karthik <a class="moz-txt-link-rfc2396E" href="mailto:karthik.b.s@intel.com"><karthik.b.s@intel.com></a>; Joshi, Kunal1 <a class="moz-txt-link-rfc2396E" href="mailto:kunal1.joshi@intel.com"><kunal1.joshi@intel.com></a>; Lattannavar, Sameer <a class="moz-txt-link-rfc2396E" href="mailto:sameer.lattannavar@intel.com"><sameer.lattannavar@intel.com></a>; Samala, Pranay <a class="moz-txt-link-rfc2396E" href="mailto:pranay.samala@intel.com"><pranay.samala@intel.com></a> Subject: [PATCH i-g-t v2 1/2] tests/kms_atomic_transition: Use extended flag for local execution There is no need to reduce the debug log level for local executions. This flag is used to prevent the reduction of the debug log level in local environments, while it will lower the log level in CI environments. To avoid reducing the debug log level in local executions, the extended flag must be explicitly used. Signed-off-by: Pranay Samala <a class="moz-txt-link-rfc2396E" href="mailto:pranay.samala@intel.com"><pranay.samala@intel.com></a> --- tests/kms_atomic_transition.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c index f4f8afc66..f11e846d8 100644 --- a/tests/kms_atomic_transition.c +++ b/tests/kms_atomic_transition.c @@ -1189,13 +1189,15 @@ igt_main_args("", long_opts, help_str, opt_handler, &data) for_each_connected_output(&data.display, output) count++; - dir = igt_sysfs_drm_module_params_open(); - if (dir >= 0) { - current_log_level = igt_drm_debug_level_get(dir); - close(dir); - - if (current_log_level > 10) - igt_drm_debug_level_update(10); + if (!data.extended) { + dir = igt_sysfs_drm_module_params_open(); + if (dir >= 0) { + current_log_level = igt_drm_debug_level_get(dir); + close(dir); + + if (current_log_level > 10) + igt_drm_debug_level_update(10); + } } }</pre> </blockquote>  <pre style="margin-bottom:7.5pt;line-height:10.75pt; background:white;word-break:break-all"><span style="font-family:Consolas; color:#333333">LGTM,</span></pre> <pre style="margin-bottom:7.5pt; line-height:10.75pt;background:white;word-break:break-all"><span class="reviewed-by"><span style="box-sizing: border-box"><span style="font-family: Consolas;color:#333333">Reviewed-by: Naladala Ramanaidu <a href="mailto:ramanaidu.naladala@intel.com"><ramanaidu.naladala@intel.com></a></span></span></span></pre> <blockquote type="cite" cite="mid:PH7PR11MB6053D85677A7EDB6C2071357E7582@PH7PR11MB6053.namprd11.prod.outlook.com"> <pre wrap="" class="moz-quote-pre"> -- 2.34.1 </pre> </blockquote> </body> </html>