<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<div class="moz-cite-prefix">On 11/19/2024 16:55, Marcin Bernatowicz
wrote:<br>
</div>
<blockquote type="cite" cite="mid:20241119155538.605000-4-marcin.bernatowicz@linux.intel.com">
<pre wrap="" class="moz-quote-pre">Mark the ggtt-clear subcheck as SKIP when prerequisites, such as scanning
GGTT provisioned offsets, are not met. Asserting in these cases falsely
implies that FLR is broken, while the test has not even started.
Signed-off-by: Marcin Bernatowicz <a class="moz-txt-link-rfc2396E" href="mailto:marcin.bernatowicz@linux.intel.com"><marcin.bernatowicz@linux.intel.com></a>
Cc: Adam Miszczak <a class="moz-txt-link-rfc2396E" href="mailto:adam.miszczak@linux.intel.com"><adam.miszczak@linux.intel.com></a>
Cc: C V Narasimha <a class="moz-txt-link-rfc2396E" href="mailto:narasimha.c.v@intel.com"><narasimha.c.v@intel.com></a>
Cc: Jakub Kolakowski <a class="moz-txt-link-rfc2396E" href="mailto:jakub1.kolakowski@intel.com"><jakub1.kolakowski@intel.com></a>
Cc: K V P Satyanarayana <a class="moz-txt-link-rfc2396E" href="mailto:satyanarayana.k.v.p@intel.com"><satyanarayana.k.v.p@intel.com></a>
Cc: Lukasz Laguna <a class="moz-txt-link-rfc2396E" href="mailto:lukasz.laguna@intel.com"><lukasz.laguna@intel.com></a>
Cc: Michał Wajdeczko <a class="moz-txt-link-rfc2396E" href="mailto:michal.wajdeczko@intel.com"><michal.wajdeczko@intel.com></a>
Cc: Michał Winiarski <a class="moz-txt-link-rfc2396E" href="mailto:michal.winiarski@intel.com"><michal.winiarski@intel.com></a>
Cc: Piotr Piórkowski <a class="moz-txt-link-rfc2396E" href="mailto:piotr.piorkowski@intel.com"><piotr.piorkowski@intel.com></a>
Cc: Tomasz Lis <a class="moz-txt-link-rfc2396E" href="mailto:tomasz.lis@intel.com"><tomasz.lis@intel.com></a>
---
tests/intel/xe_sriov_flr.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/tests/intel/xe_sriov_flr.c b/tests/intel/xe_sriov_flr.c
index 1049cffec..502691765 100644
--- a/tests/intel/xe_sriov_flr.c
+++ b/tests/intel/xe_sriov_flr.c
@@ -393,7 +393,12 @@ static int populate_ggtt_pte_offsets(struct ggtt_data *gdata)
if (vf_id == 0)
continue;
- igt_assert(vf_id >= 1 && vf_id <= num_vfs);
+ if (vf_id < 1 || vf_id > num_vfs) {
+ set_skip_reason(&gdata->base, "Unexpected VF%u at range entry %u [%#lx-%#lx], num_vfs=%u\n",</pre>
</blockquote>
<br>
nit: Unexpected VF ID (%u)...<br>
<br>
<blockquote type="cite" cite="mid:20241119155538.605000-4-marcin.bernatowicz@linux.intel.com">
<pre wrap="" class="moz-quote-pre">
+ vf_id, i, ranges[i].start, ranges[i].end, num_vfs);
+ free(ranges);
+ return -1;
+ }
if (gdata->pte_offsets[vf_id].end) {
set_skip_reason(&gdata->base, "Duplicate GGTT PTE offset range for VF%u\n",
@@ -410,7 +415,7 @@ static int populate_ggtt_pte_offsets(struct ggtt_data *gdata)
for (int vf_id = 1; vf_id <= num_vfs; ++vf_id)
if (!gdata->pte_offsets[vf_id].end) {
- set_fail_reason(&gdata->base,
+ set_skip_reason(&gdata->base,
"Failed to find VF%u provisioned GGTT PTE offset range\n",
vf_id);
return -1;
@@ -440,7 +445,7 @@ static void ggtt_subcheck_init(struct subcheck_data *data)
populate_ggtt_pte_offsets(gdata);
} else {
- set_fail_reason(data, "xe_mmio is NULL\n");
+ set_skip_reason(data, "xe_mmio is NULL\n");
}
}
</pre>
</blockquote>
<br>
Looks good overall,<span lang="en-US"> but I see that we still fail
in case of other prerequisites not met (LMEM, GGTT write/read, no
access to MMIO, etc). Maybe we should skip in these cases too?<br>
<br>
Lukasz<br>
<br>
<br>
</span><span style="white-space: pre-wrap">
</span>
</body>
</html>