<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#467886" vlink="#96607D" style="word-wrap:break-word"> <div class="WordSection1"> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Joshi, Kunal1 <kunal1.joshi@intel.com> <br> <b>Sent:</b> Monday, December 9, 2024 1:36 PM<br> <b>To:</b> B, Jeevan <jeevan.b@intel.com>; igt-dev@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH i-g-t 1/2] tests/chamelium/kms_chamelium_hpd: don't unplug multiple times<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:black">Thanks Jeevan for taking a look,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt">Apart from this it looks good to me. <o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt">Reviewed-by: Jeevan B <<a href="mailto:jeevan.b@intel.com">jeevan.b@intel.com</a>><o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p> </div> <div id="divRplyFwdMsg"> <div> <p class="MsoNormal"><span style="font-size:11.0pt">> -----Original Message-----<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt">> From: igt-dev <<a href="mailto:igt-dev-bounces@lists.freedesktop.org">igt-dev-bounces@lists.freedesktop.org</a>> On Behalf Of Kunal<br> > Joshi<br> > Sent: Thursday, December 5, 2024 3:11 PM<br> > To: <a href="mailto:igt-dev@lists.freedesktop.org">igt-dev@lists.freedesktop.org</a><br> > Cc: Joshi, Kunal1 <<a href="mailto:kunal1.joshi@intel.com">kunal1.joshi@intel.com</a>><br> > Subject: [PATCH i-g-t 1/2] tests/chamelium/kms_chamelium_hpd: don't<br> > unplug multiple times<br> ><br> > chamelium_reset_state will unplug all the ports, prevent unplugging multiple<br> > times<br> If this is fixing any issue ?? or Just a clean up ??<br> ><br> <span style="color:black">Yes this should fix xe#3505,<br> Will add a Fixes tag, let me know if any other issues,<br> Will send all together in v2.<br> <br> Thanks and Regards<br> Kunal Joshi</span><o:p></o:p></span></p> </div> <div> <p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:11.0pt">> Signed-off-by: Kunal Joshi <<a href="mailto:kunal1.joshi@intel.com">kunal1.joshi@intel.com</a>><br> > ---<br> > tests/chamelium/kms_chamelium_hpd.c | 4 ----<br> > 1 file changed, 4 deletions(-)<br> ><br> > diff --git a/tests/chamelium/kms_chamelium_hpd.c<br> > b/tests/chamelium/kms_chamelium_hpd.c<br> > index 52e758087..76a691043 100644<br> > --- a/tests/chamelium/kms_chamelium_hpd.c<br> > +++ b/tests/chamelium/kms_chamelium_hpd.c<br> > @@ -329,10 +329,6 @@ static void<br> > test_hotplug_for_each_pipe(chamelium_data_t *data,<br> > data->ports, data->port_count);<br> ><br> > igt_hpd_storm_set_threshold(data->drm_fd, 0);<br> > - /* Disconnect if any port got connected */<br> > - chamelium_unplug(data->chamelium, port);<br> > - chamelium_wait_for_connector_after_hotplug(data, mon, port,<br> > -<br> > DRM_MODE_DISCONNECTED);<br> ><br> > for_each_pipe(&data->display, pipe) {<br> > igt_modeset_disable_all_outputs(&data->display);<br> > --<br> > 2.25.1<o:p></o:p></span></p> </div> </div> </div> </div> </body> </html>