<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Hi Pranay,</div> <div id="appendonsend"></div> <div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> </div> <hr style="display: inline-block; width: 98%;"> <div id="divRplyFwdMsg" dir="ltr">From: Samala, Pranay <pranay.samala@intel.com> Sent: Tuesday, December 3, 2024 3:11 PM To: Reddy Guddati, Santhosh <santhosh.reddy.guddati@intel.com>; igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org> Cc: B S, Karthik <karthik.b.s@intel.com>; Reddy Guddati, Santhosh <santhosh.reddy.guddati@intel.com> Subject: RE: [PATCH i-g-t v1 1/1] tests/kms_invalid_mode: Add ultrajoiner support to adjust_mode_clock_too_high <div> </div> </div> <div class="elementToProof" style="font-size: 11pt;">Hi Santosh, No need of cover-letter for one patch series</div> <div class="elementToProof" style="font-size: 11pt;"> </div> <div class="elementToProof" style="font-size: 11pt;">Thank you, I understand that for a single patch, a cover letter seems to be not necessary. I included it here assuming new patches would be added. I will consider removing the cover letter for future patch series. > -----Original Message----- > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Santhosh > Reddy Guddati > Sent: Tuesday, December 3, 2024 12:14 PM > To: igt-dev@lists.freedesktop.org > Cc: B S, Karthik <karthik.b.s@intel.com>; Reddy Guddati, Santhosh > <santhosh.reddy.guddati@intel.com> > Subject: [PATCH i-g-t v1 1/1] tests/kms_invalid_mode: Add ultrajoiner support to > adjust_mode_clock_too_high > > Check ultrajoiner support on the output and adjust `max_dotclock` accordingly. > > Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com> > --- > tests/kms_invalid_mode.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c index > 4fd644594..5f13efddb 100644 > --- a/tests/kms_invalid_mode.c > +++ b/tests/kms_invalid_mode.c > @@ -34,6 +34,7 @@ > */ > > #include "igt.h" > +#include "xe/xe_query.h" > #include <limits.h> > #include <stdbool.h> > > @@ -99,6 +100,28 @@ can_bigjoiner(data_t *data) > return false; > } > > +static bool > +can_ultrajoiner(data_t *data) > +{ > + bool ultra_joiner_supported = false; > + bool is_dgfx; > + int display_ver; > + > + is_dgfx = is_xe_device(data->drm_fd) ? xe_has_vram(data->drm_fd) : > + gem_has_lmem(data->drm_fd); > + display_ver = intel_display_ver(intel_get_drm_devid(data->drm_fd)); > + > + if ((is_dgfx && display_ver == 14) || (display_ver > 14)) No need of parentheses around 'display_ver > 14' > + ultra_joiner_supported = true; > + > + if (ultra_joiner_supported) { > + igt_debug("Platform supports ultrajoiner\n"); > + return true; > + } > + > + return false; > +} > + > static bool > adjust_mode_clock_too_high(data_t *data, drmModeModeInfoPtr mode) { @@ > -128,6 +151,12 @@ adjust_mode_clock_too_high(data_t *data, > drmModeModeInfoPtr mode) > max_dotclock *= 2; > } > > + if (can_ultrajoiner(data)) { > + igt_info("Platform supports ultrajoiner with %s\n", > + data->output->name); Alignment should match open parenthesis Regards, Pranay Samala > + max_dotclock *= 4; > + } > + > mode->clock = max_dotclock + 1; > > return true; > -- > 2.34.1 </div> </body> </html>